Commit graph

671 commits

Author SHA1 Message Date
joshua stein 20c870b78b spacing nit 2014-02-17 10:09:33 -06:00
joshua stein 9d16898477 User: move "new account" age into constant 2014-02-17 10:09:08 -06:00
joshua stein 1d5b004a36 Story: alpha sort methods, no functional changes 2014-02-17 10:07:36 -06:00
joshua stein 9918660ab4 Comment: alpha sort methods, no functional changes 2014-02-17 10:01:44 -06:00
joshua stein 0d6f4ed60c fix story pagination and caching for logged-out users
use a file store so each unicorn process can share the same set of
files (using redis would probably be cleaner)

put page number into how hash when creating the cache key
2014-02-16 09:57:05 -06:00
joshua stein a16e99c686 avoid leaking object ids in form_fors 2014-02-12 13:28:53 -06:00
joshua stein 354143e9c5 mobile story view: align things a bit better, shorter markdown help label 2014-02-08 14:41:36 -06:00
joshua stein 5d5b920f5b mobile story list: make comment links easier to click on 2014-02-08 14:28:27 -06:00
joshua stein 2da624e592 use Rails.env.development? 2014-02-05 21:01:49 -06:00
joshua stein a85fbe4ff1 bring back moderation_reason for moderators 2014-02-05 21:01:49 -06:00
joshua stein 890636a0f1 Merge pull request #130 from srgpqt/master
fix improper usage of strong parameters in FiltersController
2014-02-05 21:00:08 -06:00
Serge Paquet 70a70096db fix improper usage of strong parameters in FiltersController 2014-02-05 17:02:12 -05:00
joshua stein f9778044f0 try to strip out attributed text from incoming e-mails 2014-02-03 19:27:54 -06:00
joshua stein b75468a2c9 move inbound e-mail parsing guts into an extra, add tests for it 2014-02-03 19:06:20 -06:00
joshua stein 2f55605645 Merge pull request #126 from srgpqt/master
use Rails4-style strong parameters mass assignment protection
2014-02-03 17:04:55 -08:00
Serge Paquet 9013afa43b do not permit story moderation_reason to pass mass assignment security 2014-02-03 17:14:49 -05:00
joshua stein 49a116a12e "edited by e-mail" doesn't make much sense 2014-02-03 14:37:31 -06:00
joshua stein 9d1a1bdcf9 lighten highlighted comments a bit 2014-02-03 14:37:22 -06:00
Serge Paquet 519427586a use Rails4-style strong parameters mass assignment protection 2014-02-02 15:41:38 -05:00
joshua stein 7584a15e53 Merge pull request #125 from srgpqt/master
fix pushover messages user setting
2014-02-02 12:01:19 -08:00
Serge Paquet 22d6ec20a7 fix pushover messages user setting 2014-02-02 14:49:34 -05:00
joshua stein 9fb9a6f116 fix /recent behavior when there aren't enough stories to fill the list
keep walking back a day at a time
(might want to do this quicker though)
2014-02-01 03:39:58 -06:00
joshua stein 91b3fe77fe add twitter-posting script that has been running for a while
closes #124
2014-01-31 22:26:18 -06:00
joshua stein 479c02415e auto assign ask/show tags when story title has "(show|ask) lobsters"
and strip out that segment from the title since it is redundant
2014-01-30 09:42:58 -06:00
joshua stein 6ef2596eed project tag renamed to show 2014-01-30 09:42:46 -06:00
joshua stein 6cca9f64e5 Pushover: return a hash from self.sounds when no api key configured
fixes #120
2014-01-28 13:19:30 -06:00
joshua stein df75c8f787 revert to previous /newest behavior, use new stuff for /recent
/recent is not yet linked to from anywhere
2014-01-25 11:14:21 -06:00
joshua stein 8dbc0e4724 simplify story finding 2014-01-25 10:38:07 -06:00
joshua stein 35f43ea10c start experiment with /newest page
on the first page of /newest, shift out stories that got enough
traction that they're probably on the front page (currently 5
points)

then take the bottom half of the list and fill it with random,
unpopular stories from the past few days (currently 3)
2014-01-24 13:55:21 -06:00
joshua stein 20cf2bab65 show how many stories have been tagged with each on filters page
closes #93
closes #114
2014-01-24 13:53:10 -06:00
joshua stein b0b6b72cf3 Merge pull request #116 from srgpqt/format
be explicit about which route formats are accepted

stop generating ActionView::MissingTemplate 500 errors for actions that don't have json views when manually requesting them
2014-01-23 09:00:15 -08:00
Serge Paquet 981759c34f be explicit about which route formats are accepted 2014-01-22 20:13:42 -05:00
joshua stein fe83a5b780 use false instead of 0 for boolean column in where clause
fixes #113
2014-01-21 20:53:29 -06:00
joshua stein 71eeb6c7d2 be a good pushover user and let the user specify a sound
- move pushover particulars into User model
- Pushover class rescues errors, don't need to do it from User
2014-01-21 01:21:02 -06:00
joshua stein 00f8e9c189 use one of gravatar's default avatars rather than our own 2014-01-21 00:22:40 -06:00
joshua stein e6ce3a5d68 show full story threads when highlighting a comment
we're not paginating (yet) so just show the whole thread like normal
and highlight the specific comment which gets scrolled to

closes #107
2014-01-20 23:30:46 -06:00
joshua stein d277011a0f tighten up comment tree spacing just a tad 2014-01-20 22:29:02 -06:00
joshua stein 700d338b23 unbreak story previews
@comments is nil, but there's no point in showing an empty comment
tree anyway
2014-01-20 21:18:03 -06:00
joshua stein 3c7393c6a3 give tedu his karma back
fix bug introduced in 3757b279 that gave comment vote karma to the
voter rather than the commenter
2014-01-20 20:22:45 -06:00
joshua stein 1a0457c7be Merge pull request #111 from srgpqt/master
enable "reply" function on the "Comments" page
2014-01-20 18:08:36 -08:00
Serge Paquet 5bca469035 enable "reply" function on the "Comments" page 2014-01-20 21:04:54 -05:00
joshua stein 27caa0a7a6 Merge pull request #106 from srgpqt/recent_threads
fix User#recent_threads for postgresql
2014-01-20 17:27:03 -08:00
joshua stein c764814ee5 Merge pull request #104 from srgpqt/master
fix DOM structure when replying to or updating comments
2014-01-20 17:26:33 -08:00
Serge Paquet 79b64c3883 use standard create/update comment routes 2014-01-20 16:52:19 -05:00
Serge Paquet 42ce1e3b4c rebuilt comment tree DOM structure as valid HTML 2014-01-20 16:52:19 -05:00
Serge Paquet 41c9dfad5d fix DOM structure when replying to or updating comments 2014-01-20 16:52:19 -05:00
Serge Paquet 02a30c66b1 optimize database queries for "Your Threads" page 2014-01-20 16:44:14 -05:00
joshua stein 7d10b5eb06 Merge pull request #108 from abutler3/master
add tests for recent changes to User model
2014-01-20 09:14:27 -08:00
Drew Butler 544a521c78 Create user model tests for is_active, unban, is_banned and is_new 2014-01-19 08:50:39 -06:00
Drew Butler 2cd248d122 Test-user receives message after registering banned username 2014-01-18 13:32:57 -06:00