deblan/journalduhacker
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
593 commits 2 branches 0 tags 1.9 MiB
Commit graph

470 commits

Author SHA1 Message Date
joshua stein d4e9e024aa invitation requests: <em> emails 2014-02-21 10:57:30 -06:00
Radu Voicilas fa946933ab Fix typo Invitiation -> Invitation 2014-02-21 11:25:33 +02:00
joshua stein d0711892f6 messages: implement batch-delete function 
closes #119
 2014-02-19 13:31:48 -06:00
joshua stein 8755384bd8 invitation requests: show confirmed e-mails to moderators 2014-02-19 13:16:23 -06:00
joshua stein c90486b813 invitation requests: allow moderators to delete confirmed requests 2014-02-19 13:16:23 -06:00
joshua stein 78d9734c26 invitation requests: use a proper form_for, highlight errors 2014-02-19 13:16:16 -06:00
joshua stein 89cdf1101a add a story-only mailing list mode 
closes #131
 2014-02-19 12:49:12 -06:00
joshua stein 67fc2cc75c set maximum time during which comments and stories can be downvoted 
always allow a user to "unvote" if they're previously downvoted, but
after a certain number of days, don't accept new downvotes

there isn't really any benefit in downvoting old stuff that is
already off the front pages or on a dead comment thread, other than
to maliciously strip karma for particular users
 2014-02-17 12:08:01 -06:00
joshua stein 20c870b78b spacing nit 2014-02-17 10:09:33 -06:00
joshua stein 9d16898477 User: move "new account" age into constant 2014-02-17 10:09:08 -06:00
joshua stein 1d5b004a36 Story: alpha sort methods, no functional changes 2014-02-17 10:07:36 -06:00
joshua stein 9918660ab4 Comment: alpha sort methods, no functional changes 2014-02-17 10:01:44 -06:00
joshua stein 0d6f4ed60c fix story pagination and caching for logged-out users 
use a file store so each unicorn process can share the same set of
files (using redis would probably be cleaner)

put page number into how hash when creating the cache key
 2014-02-16 09:57:05 -06:00
joshua stein a16e99c686 avoid leaking object ids in form_fors 2014-02-12 13:28:53 -06:00
joshua stein 354143e9c5 mobile story view: align things a bit better, shorter markdown help label 2014-02-08 14:41:36 -06:00
joshua stein 5d5b920f5b mobile story list: make comment links easier to click on 2014-02-08 14:28:27 -06:00
joshua stein 2da624e592 use Rails.env.development? 2014-02-05 21:01:49 -06:00
joshua stein a85fbe4ff1 bring back moderation_reason for moderators 2014-02-05 21:01:49 -06:00
Serge Paquet 70a70096db fix improper usage of strong parameters in FiltersController 2014-02-05 17:02:12 -05:00
joshua stein 2f55605645 Merge pull request #126 from srgpqt/master 
use Rails4-style strong parameters mass assignment protection
 2014-02-03 17:04:55 -08:00
Serge Paquet 9013afa43b do not permit story moderation_reason to pass mass assignment security 2014-02-03 17:14:49 -05:00
joshua stein 49a116a12e "edited by e-mail" doesn't make much sense 2014-02-03 14:37:31 -06:00
joshua stein 9d1a1bdcf9 lighten highlighted comments a bit 2014-02-03 14:37:22 -06:00
Serge Paquet 519427586a use Rails4-style strong parameters mass assignment protection 2014-02-02 15:41:38 -05:00
Serge Paquet 22d6ec20a7 fix pushover messages user setting 2014-02-02 14:49:34 -05:00
joshua stein 9fb9a6f116 fix /recent behavior when there aren't enough stories to fill the list 
keep walking back a day at a time
(might want to do this quicker though)
 2014-02-01 03:39:58 -06:00
joshua stein 479c02415e auto assign ask/show tags when story title has "(show|ask) lobsters" 
and strip out that segment from the title since it is redundant
 2014-01-30 09:42:58 -06:00
joshua stein 6ef2596eed project tag renamed to show 2014-01-30 09:42:46 -06:00
joshua stein df75c8f787 revert to previous /newest behavior, use new stuff for /recent 
/recent is not yet linked to from anywhere
 2014-01-25 11:14:21 -06:00
joshua stein 8dbc0e4724 simplify story finding 2014-01-25 10:38:07 -06:00
joshua stein 35f43ea10c start experiment with /newest page 
on the first page of /newest, shift out stories that got enough
traction that they're probably on the front page (currently 5
points)

then take the bottom half of the list and fill it with random,
unpopular stories from the past few days (currently 3)
 2014-01-24 13:55:21 -06:00
joshua stein 20cf2bab65 show how many stories have been tagged with each on filters page 
closes #93
closes #114
 2014-01-24 13:53:10 -06:00
joshua stein fe83a5b780 use false instead of 0 for boolean column in where clause 
fixes #113
 2014-01-21 20:53:29 -06:00
joshua stein 71eeb6c7d2 be a good pushover user and let the user specify a sound 
- move pushover particulars into User model
- Pushover class rescues errors, don't need to do it from User
 2014-01-21 01:21:02 -06:00
joshua stein 00f8e9c189 use one of gravatar's default avatars rather than our own 2014-01-21 00:22:40 -06:00
joshua stein e6ce3a5d68 show full story threads when highlighting a comment 
we're not paginating (yet) so just show the whole thread like normal
and highlight the specific comment which gets scrolled to

closes #107
 2014-01-20 23:30:46 -06:00
joshua stein d277011a0f tighten up comment tree spacing just a tad 2014-01-20 22:29:02 -06:00
joshua stein 700d338b23 unbreak story previews 
@comments is nil, but there's no point in showing an empty comment
tree anyway
 2014-01-20 21:18:03 -06:00
joshua stein 3c7393c6a3 give tedu his karma back 
fix bug introduced in 3757b279 that gave comment vote karma to the
voter rather than the commenter
 2014-01-20 20:22:45 -06:00
Serge Paquet 5bca469035 enable "reply" function on the "Comments" page 2014-01-20 21:04:54 -05:00
joshua stein 27caa0a7a6 Merge pull request #106 from srgpqt/recent_threads 
fix User#recent_threads for postgresql
 2014-01-20 17:27:03 -08:00
Serge Paquet 79b64c3883 use standard create/update comment routes 2014-01-20 16:52:19 -05:00
Serge Paquet 42ce1e3b4c rebuilt comment tree DOM structure as valid HTML 2014-01-20 16:52:19 -05:00
Serge Paquet 41c9dfad5d fix DOM structure when replying to or updating comments 2014-01-20 16:52:19 -05:00
Serge Paquet 02a30c66b1 optimize database queries for "Your Threads" page 2014-01-20 16:44:14 -05:00
joshua stein 8c3841331d when highlighting one comment, scroll to it 
though i wonder with highlighting comments and now scrolling to
them, why we bother excluding all other threads.  we aren't
pagingating threads anyway.
 2014-01-18 13:13:58 -06:00
Serge Paquet 577ce2307b fix User#recent_threads for postgresql 2014-01-16 21:33:00 -05:00
joshua stein dd860f06e3 also escape ~ char before sending to sphinx 2014-01-14 21:53:46 -06:00
Serge Paquet 305c992709 possible fix for postgresql+sphinx indexing issue? 2014-01-14 21:42:27 -05:00
Serge Paquet cb695a1522 optimize traffic counter queries 2014-01-14 21:42:27 -05:00
Serge Paquet d74a2c448f add postgresql support 2014-01-14 21:42:27 -05:00
joshua stein 5f6c13b26b Merge pull request #98 from srgpqt/master 
remove redundant "story" variable in comment templates
 2014-01-14 18:34:07 -08:00
joshua stein be2c706c06 fix Tag.accessible_to to allow moderators to use privileged tags 2014-01-14 11:39:56 -06:00
joshua stein 566c1090e8 apply comment_text class to private messages to get nicer formatting 2014-01-14 11:39:56 -06:00
joshua stein 3241f34f75 don't interact with inactive users 2014-01-14 11:39:56 -06:00
joshua stein e12d91cd43 allow users to delete their own accounts 
not much can actually be deleted, but it can be put into a deleted
state
 2014-01-13 10:12:17 -06:00
Serge Paquet aabe4ceed7 remove redundant "story" variable in comment templates 2014-01-13 02:11:34 -05:00
joshua stein 1ef58d6496 search: fix busted scope introduced in sphinx update 2014-01-13 00:59:37 -06:00
joshua stein da560f1da4 search: fix radio button labels 2014-01-13 00:55:36 -06:00
joshua stein 65a9a77104 Merge pull request #92 from srgpqt/filters 
simplify and optimize Filters controller and template
 2014-01-12 22:34:09 -08:00
joshua stein 4cfa2dae27 Merge pull request #86 from srgpqt/master 
refactor Comment#ordered_for_story_or_thread_for_user method
 2014-01-12 22:30:27 -08:00
joshua stein fcfd472723 don't show invitation queue to new users 
this is just the link to it though, so new users can still invite
from the queue if they know what they're doing
 2014-01-13 00:12:43 -06:00
joshua stein f1f6b3c7e0 alert the user when submitting a long-ago-submitted story 
show the user a link to the previous story and let them know they
can submit it again if they want to (just by submitting the form
again)
 2014-01-13 00:10:31 -06:00
joshua stein 22b77573a5 prevent new users from downvoting 
don't show downvote arrows for logged-out and new users

color comments from new users in green like in the user tree,
and banned users in gray
 2014-01-12 23:17:09 -06:00
joshua stein 0989d6b30b also log a moderation when a user is banned 2014-01-12 19:22:08 -06:00
joshua stein 287be48187 add stuff to deal with banning users 2014-01-12 15:09:32 -06:00
joshua stein 68a1f02a1c name /u/:username route 2014-01-12 14:22:47 -06:00
joshua stein 2b93c1217b log user id when logged in 2014-01-12 13:28:08 -06:00
joshua stein 7abb4636dd reduce access required for privileged tags to just moderator 2014-01-12 13:28:07 -06:00
joshua stein ccae78bf34 if user is not logged in, prevent downloading application.js 
saves a lot of time for users downloading and processing jquery and
other code that is never used when logged out
 2014-01-12 13:28:07 -06:00
Conor Mongey a069749c65 Fix issue #96. Direct users back to root URL via get instead of post 2014-01-10 23:52:40 +00:00
Serge Paquet 2c906efa7e simplify and optimize Filters controller and template 2014-01-09 01:44:03 -05:00
Serge Paquet e2c266af4b simplify Comment#arrange_for_user method 2014-01-08 23:48:24 -05:00
Serge Paquet 5988038071 make Comment#ordered_for_story_or_thread_for_user work on query scope 2014-01-08 23:48:24 -05:00
joshua stein cd7cb552e7 story detail: don't mock non-users by showing a discuss link 
fixes #91
 2014-01-08 22:20:56 -06:00
joshua stein d578482e3b move story comment counts out of keystore 
it would be nice to use AR's built-in counter cache, but the
comments count has to reflect something custom so stick with what
was there
 2014-01-08 22:20:56 -06:00
joshua stein 9bab78634e don't show endless comment link pages 
stop when there are no more comments
 2014-01-08 20:42:25 -06:00
joshua stein 2f824a73a3 shrink story hotness window, things are moving faster now 2014-01-08 20:42:25 -06:00
joshua stein 53a6d87ead speed up traffic decrementer 2014-01-08 20:42:25 -06:00
joshua stein 9a6cccfde0 grey out meta tag 2014-01-08 20:42:24 -06:00
joshua stein 40e4c10e26 fix busted PM e-mail notifications 
do e-mail and pushover deliveries separately, catch and log errors
from each

closes #90
 2014-01-08 20:42:24 -06:00
joshua stein 345388079e Merge pull request #83 from srgpqt/sphinx 
upgrade thinking-sphinx gem; requires sphinx >= 2.0.6
 2014-01-07 10:17:31 -08:00
joshua stein 1c3597004f Merge pull request #81 from srgpqt/master 
simplify user tree controller action and template
 2014-01-07 09:57:09 -08:00
joshua stein e6db99c956 disable autocomplete for text fields that shouldn't use it 
new password on settings form and user invitation form (would be
another e-mail address, not the stored user's)

closes #85
 2014-01-07 11:42:21 -06:00
joshua stein c576f86e4d in moderation auto-message, tell the user it's automated 2014-01-07 11:42:21 -06:00
joshua stein 1452e1c34d rip out default filtered tags 2014-01-07 11:42:21 -06:00
joshua stein d959977ca1 color 'ask' tag specially 2014-01-07 11:42:21 -06:00
joshua stein 831b576325 only show invitation queue link if there are any pending 2014-01-07 11:42:21 -06:00
joshua stein ce495470c6 double max comment edit time to 90 minutes 2014-01-07 11:42:20 -06:00
Serge Paquet 709b0bff98 upgrade thinking-sphinx gem 2014-01-07 05:52:29 -05:00
Serge Paquet b8652d80cc simplify user tree controller action and template 2014-01-04 03:14:41 -05:00
Serge Paquet a46194d1be add Search#page_count method 2014-01-02 12:16:14 -05:00
joshua stein fcd2c10c08 Merge pull request #76 from srgpqt/master 
add karma column to users table, move out of keystore
 2014-01-02 08:53:51 -08:00
joshua stein cc59b4b475 story guidelines toggler was moved to application.js 2014-01-02 10:10:25 -06:00
joshua stein 50aa8434f9 Merge pull request #59 from imwally/master 
add story submission guidelines to the edit page
 2014-01-02 08:09:05 -08:00
Serge Paquet 3757b279ff add karma column to users table 2014-01-01 16:03:01 -05:00
Serge Paquet 9b0294c471 upgrade to rails v4.0.2 2013-12-30 17:40:52 -05:00
Serge Paquet b42189f45b replace some raw sql with database-agnostic activerecord queries 2013-12-30 16:23:59 -05:00
joshua stein f8f35c6177 Merge pull request #73 from srgpqt/jquery-fixes 
move inline js from story submission page into application.js
 2013-12-29 08:09:54 -08:00
Serge Paquet 3c63f930cd more jQuery.fn.live fixes for the "submit story" page 2013-12-28 22:17:08 -05:00