From 852d0d60078d93aa4e324c49e7c810ef4436aa5e Mon Sep 17 00:00:00 2001 From: Lukas Metzger Date: Tue, 27 Mar 2018 19:51:29 +0200 Subject: [PATCH] Fixed missing type parameters for SQL bindValue calls --- backend/src/operations/Domains.php | 6 +++--- backend/src/operations/Soa.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backend/src/operations/Domains.php b/backend/src/operations/Domains.php index b27a2a2..5e28345 100644 --- a/backend/src/operations/Domains.php +++ b/backend/src/operations/Domains.php @@ -239,7 +239,7 @@ class Domains public function getDomainType(int $id) : string { $query = $this->db->prepare('SELECT type FROM domains WHERE id=:id'); - $query->bindValue(':id', $id); + $query->bindValue(':id', $id, \PDO::PARAM_INT); $query->execute(); $record = $query->fetch(); @@ -268,8 +268,8 @@ class Domains } $query = $this->db->prepare('UPDATE domains SET master=:master WHERE id=:id'); - $query->bindValue(':id', $id); - $query->bindValue(':master', $master); + $query->bindValue(':id', $id, \PDO::PARAM_INT); + $query->bindValue(':master', $master, \PDO::PARAM_STR); $query->execute(); } } diff --git a/backend/src/operations/Soa.php b/backend/src/operations/Soa.php index c02a470..9a42628 100644 --- a/backend/src/operations/Soa.php +++ b/backend/src/operations/Soa.php @@ -45,7 +45,7 @@ class Soa $this->db->beginTransaction(); $query = $this->db->prepare('SELECT id,name,type FROM domains WHERE id=:id'); - $query->bindValue(':id', $domainId); + $query->bindValue(':id', $domainId, \PDO::PARAM_INT); $query->execute(); $record = $query->fetch(); @@ -71,7 +71,7 @@ class Soa ]; $query = $this->db->prepare('SELECT content FROM records WHERE domain_id=:id AND type=\'SOA\''); - $query->bindValue(':id', $domainId); + $query->bindValue(':id', $domainId, \PDO::PARAM_INT); $query->execute(); $content = $query->fetch(); @@ -154,7 +154,7 @@ class Soa public function updateSerial(int $domainId) : void { $query = $this->db->prepare('SELECT content FROM records WHERE domain_id=:id AND type=\'SOA\''); - $query->bindValue(':id', $domainId); + $query->bindValue(':id', $domainId, \PDO::PARAM_INT); $query->execute(); $content = $query->fetch();