deblan/php-censor
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make check for Pdepend output dir more robust. Before this fix, the pdepend module would check for "is_writable", which returns false even when the directory does not exist. I suggest to a) attempt to crete the dir if it does not exist, and b) make the error message more explanatory in case the dir cannot be created or is not accessible.

Browse source
This commit is contained in:
mulleto 2015-05-29 08:26:47 +02:00
parent a22390c83d
commit 01765dfbfa
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
PHPCI/Plugin/Pdepend.php
View file

@ -73,8 +73,11 @@ class Pdepend implements \PHPCI\Plugin
*/
public function execute()
{
if (!file_exists($this->location)) {
mkdir($this->location);
}
if (!is_writable($this->location)) {
throw new \Exception(sprintf('The location %s is not writable.', $this->location));
throw new \Exception(sprintf('The location %s is not writable or does not exist.', $this->location));
}
$pdepend = $this->phpci->findBinary('pdepend');