From 5d03a0ab35b004bcf698420de7e3fbc8604bb9df Mon Sep 17 00:00:00 2001 From: Dmitry Khomutov Date: Sun, 19 Feb 2017 01:21:46 +0700 Subject: [PATCH] Fixed extra --- src/PHPCensor/Model/Build.php | 2 -- src/PHPCensor/Service/BuildService.php | 2 +- tests/PHPCensor/Model/BuildTest.php | 2 +- tests/PHPCensor/Service/BuildServiceTest.php | 2 +- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/PHPCensor/Model/Build.php b/src/PHPCensor/Model/Build.php index b259b1bc..d4f25945 100644 --- a/src/PHPCensor/Model/Build.php +++ b/src/PHPCensor/Model/Build.php @@ -522,8 +522,6 @@ class Build extends Model */ public function setExtra($value) { - $value = json_encode($value); - $this->validateString('Extra', $value); if ($this->data['extra'] === $value) { diff --git a/src/PHPCensor/Service/BuildService.php b/src/PHPCensor/Service/BuildService.php index e40f3ff4..26017a16 100644 --- a/src/PHPCensor/Service/BuildService.php +++ b/src/PHPCensor/Service/BuildService.php @@ -87,7 +87,7 @@ class BuildService } if (!is_null($extra)) { - $build->setExtra($extra); + $build->setExtra(json_encode($extra)); } $build = $this->buildStore->save($build); diff --git a/tests/PHPCensor/Model/BuildTest.php b/tests/PHPCensor/Model/BuildTest.php index efd699f4..096fda34 100644 --- a/tests/PHPCensor/Model/BuildTest.php +++ b/tests/PHPCensor/Model/BuildTest.php @@ -63,7 +63,7 @@ class BuildTest extends \PHPUnit_Framework_TestCase ]; $build = new Build(); - $build->setExtra($info); + $build->setExtra(json_encode($info)); $this->assertEquals('Item One', $build->getExtra('item1')); $this->assertEquals(2, $build->getExtra('item2')); diff --git a/tests/PHPCensor/Service/BuildServiceTest.php b/tests/PHPCensor/Service/BuildServiceTest.php index 6cdfe63b..ba0f97ad 100644 --- a/tests/PHPCensor/Service/BuildServiceTest.php +++ b/tests/PHPCensor/Service/BuildServiceTest.php @@ -100,7 +100,7 @@ class BuildServiceTest extends \PHPUnit_Framework_TestCase $build->setFinished(new \DateTime()); $build->setCommitMessage('test'); $build->setCommitterEmail('test@example.com'); - $build->setExtra(['item1' => 1001]); + $build->setExtra(json_encode(['item1' => 1001])); $returnValue = $this->testedService->createDuplicateBuild($build);