deblan/php-censor
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Switching executeCommand() to use sprintf for parameters, and all the plugins to pass params separately. See #12, closes #24

Browse source
This commit is contained in:
Dan Cryer 2013-05-16 00:17:57 +01:00
commit a5a03e1f07
8 changed files with 19 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
PHPCI/Model/Build/RemoteGitBuild.php
View file

@ -48,7 +48,7 @@ abstract class RemoteGitBuild extends Build
protected function cloneByHttp(Builder $builder, $to)
{
return $builder->executeCommand('git clone -b ' .$this->getBranch() . ' ' .$this->getCloneUrl().' '.$to);
return $builder->executeCommand('git clone -b %s %s "%s"', $this->getBranch(), $this->getCloneUrl(), $to);
}
protected function cloneBySsh(Builder $builder, $to)
@ -59,7 +59,7 @@ abstract class RemoteGitBuild extends Build
chmod($keyFile, 0600);
// Use the key file to do an SSH clone:
$success = $builder->executeCommand('ssh-agent ssh-add '.$keyFile.' && git clone -b ' .$build->getBranch() . ' ' .$this->getCloneUrl().' '.$to.' && ssh-agent -k');
$success = $builder->executeCommand('ssh-agent ssh-add "%s" && git clone -b %s %s "%s" && ssh-agent -k', $keyFile, $build->getBranch(), $this->getCloneUrl(), $to);
// Remove the key file:
unlink($keyFile);