From a9309a1febdbe25c2396af421e065e99294d9a44 Mon Sep 17 00:00:00 2001 From: Dmitry Khomutov Date: Sun, 2 Jul 2017 16:45:25 +0700 Subject: [PATCH] sendStatusPostback fix. --- src/PHPCensor/Model/Build.php | 2 +- src/PHPCensor/Model/Build/GithubBuild.php | 19 ++++++++++++------- src/PHPCensor/Service/BuildService.php | 1 + 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/PHPCensor/Model/Build.php b/src/PHPCensor/Model/Build.php index de502d72..54d7d29e 100644 --- a/src/PHPCensor/Model/Build.php +++ b/src/PHPCensor/Model/Build.php @@ -743,7 +743,7 @@ class Build extends Model */ public function sendStatusPostback() { - return; + return false; } /** diff --git a/src/PHPCensor/Model/Build/GithubBuild.php b/src/PHPCensor/Model/Build/GithubBuild.php index 82d476e1..54f026ca 100644 --- a/src/PHPCensor/Model/Build/GithubBuild.php +++ b/src/PHPCensor/Model/Build/GithubBuild.php @@ -45,16 +45,19 @@ class GithubBuild extends RemoteGitBuild */ public function sendStatusPostback() { + if ('Manual' === $this->getCommitId()) { + return false; + } + + $project = $this->getProject(); + if (empty($project)) { + return false; + } + $token = Config::getInstance()->get('php-censor.github.token'); if (empty($token) || empty($this->data['id'])) { - return; - } - - $project = $this->getProject(); - - if (empty($project)) { - return; + return false; } switch ($this->getStatus()) { @@ -93,6 +96,8 @@ class GithubBuild extends RemoteGitBuild 'context' => 'PHP Censor', ] ]); + + return true; } /** diff --git a/src/PHPCensor/Service/BuildService.php b/src/PHPCensor/Service/BuildService.php index 61c80b5a..e4e0a67c 100644 --- a/src/PHPCensor/Service/BuildService.php +++ b/src/PHPCensor/Service/BuildService.php @@ -93,6 +93,7 @@ class BuildService $build->setExtraValues($extra); } + /** @var Build $build */ $build = $this->buildStore->save($build); $buildId = $build->getId();