deblan/php-censor
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed PHPUnit plugin (for empty tests)

Browse source
This commit is contained in:
Dmitry Khomutov 2017-03-14 22:41:23 +07:00
parent 8d82e41666
commit c97d5935b9
No known key found for this signature in database
GPG key ID: 7EB36C9576F9ECB9
2 changed files with 6 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/PHPCensor/Plugin/Util/PhpUnitResult.php
View file

@ -39,13 +39,12 @@ class PhpUnitResult
public function parse()
{
$rawResults = file_get_contents($this->outputFile);
if (empty($rawResults)) {
throw new \Exception('No test executed.');
}
if ($rawResults[0] == '{') {
$events = [];
if ($rawResults && $rawResults[0] == '{') {
$fixedJson = '[' . str_replace('}{', '},{', $rawResults) . ']';
$events = json_decode($fixedJson, true);
} else {
} elseif ($rawResults) {
$events = json_decode($rawResults, true);
}
@ -54,14 +53,12 @@ class PhpUnitResult
$this->errors = [];
$this->failures = 0;
if (is_array($events)) {
if ($events) {
foreach ($events as $event) {
if ($event['event'] == self::EVENT_TEST) {
if (isset($event['event']) && $event['event'] == self::EVENT_TEST) {
$this->results[] = $this->parseEvent($event);
}
}
} else {
throw new \Exception('Failed to parse the JSON output.');
}
return $this;

9
tests/PHPCensor/Plugin/Util/PhpUnitResultTest.php
View file

@ -36,13 +36,4 @@ class PhpUnitResultTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(PhpUnitResult::SEVERITY_SKIPPED, $output[11]['severity']);
$this->assertContains('Skipped Test:', $output[11]['message']);
}
public function testParseFailure()
{
$this->setExpectedException('\Exception', 'Failed to parse the JSON output');
$buildPath = '/path/to/build';
$parser = new PhpUnitResult(ROOT_DIR . 'tests/PHPCensor/Plugin/SampleFiles/invalid_format.txt', $buildPath);
$parser->parse();
}
}