remove unreachable if

This commit is contained in:
Steve B 2013-12-07 14:29:25 +00:00 committed by meadsteve
parent 5ae0442bf6
commit 03aeb7e3b1
8 changed files with 10 additions and 10 deletions

View file

@ -159,7 +159,7 @@ class Builder implements LoggerAwareInterface, BuildLogger
public function execute()
{
// Update the build in the database, ping any external services.
$this->build->setStatus(1);
$this->build->setStatus(Build::STATUS_RUNNING);
$this->build->setStarted(new \DateTime());
$this->store->save($this->build);
$this->build->sendStatusPostback();
@ -182,14 +182,14 @@ class Builder implements LoggerAwareInterface, BuildLogger
// If we got this far, the build was successful!
if ($this->success) {
$this->build->setStatus(2);
$this->build->setStatus(Build::STATUS_SUCCESS);
$this->pluginExecutor->executePlugins($this->config, 'success');
$this->logSuccess('BUILD SUCCESSFUL!');
}
} catch (\Exception $ex) {
$this->logFailure($ex->getMessage(), $ex);
$this->build->setStatus(3);
$this->build->setStatus(Build::STATUS_FAILED);
}
// Clean up:

View file

@ -84,7 +84,7 @@ class PollCommand extends Command
$build = new Build();
$build->setProjectId($project->getId());
$build->setCommitId($last_commit);
$build->setStatus(0);
$build->setStatus(Build::STATUS_NEW);
$build->setBranch($project->getType() === 'hg' ? 'default' : 'master');
$build->setCreated(new \DateTime());

View file

@ -53,7 +53,7 @@ class BitbucketController extends \PHPCI\Controller
$build = new Build();
$build->setProjectId($project);
$build->setCommitId($commits[$branch]);
$build->setStatus(0);
$build->setStatus(Build::STATUS_NEW);
$build->setLog('');
$build->setCreated(new \DateTime());
$build->setBranch($branch);

View file

@ -109,7 +109,7 @@ class BuildController extends \PHPCI\Controller
$build = new Build();
$build->setProjectId($copy->getProjectId());
$build->setCommitId($copy->getCommitId());
$build->setStatus(0);
$build->setStatus(Build::STATUS_NEW);
$build->setBranch($copy->getBranch());
$build->setCreated(new \DateTime());

View file

@ -47,7 +47,7 @@ class GitController extends \PHPCI\Controller
$build->setCommitId($commit);
}
$build->setStatus(0);
$build->setStatus(Build::STATUS_NEW);
$build->setLog('');
$build->setCreated(new \DateTime());
} catch (\Exception $ex) {

View file

@ -48,7 +48,7 @@ class GithubController extends \PHPCI\Controller
$build = new Build();
$build->setProjectId($project);
$build->setCommitId($payload['after']);
$build->setStatus(0);
$build->setStatus(Build::STATUS_NEW);
$build->setLog('');
$build->setCreated(new \DateTime());
$build->setBranch(str_replace('refs/heads/', '', $payload['ref']));

View file

@ -42,7 +42,7 @@ class GitlabController extends \PHPCI\Controller
$build = new Build();
$build->setProjectId($project);
$build->setCommitId($payload['after']);
$build->setStatus(0);
$build->setStatus(Build::STATUS_NEW);
$build->setLog('');
$build->setCreated(new \DateTime());
$build->setBranch(str_replace('refs/heads/', '', $payload['ref']));

View file

@ -69,7 +69,7 @@ class ProjectController extends \PHPCI\Controller
$build = new Build();
$build->setProjectId($projectId);
$build->setCommitId('Manual');
$build->setStatus(0);
$build->setStatus(Build::STATUS_NEW);
$build->setBranch($project->getType() === 'hg' ? 'default' : 'master');
$build->setCreated(new \DateTime());