deblan/phpci
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Making PHPMD happy.

Browse source
This commit is contained in:
Dan Cryer 2015-10-05 14:48:17 +01:00
parent 771bee0aa3
commit 11445304d6
2 changed files with 30 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
PHPCI/BuildFactory.php
View file

@ -37,16 +37,14 @@ class BuildFactory
/** /**
* Takes a generic build and returns a type-specific build model. * Takes a generic build and returns a type-specific build model.
* @param Build $build The build from which to get a more specific build type. * @param Build $build The build from which to get a more specific build type.
* @param string $type Set the type manually if you already know it.
* @return Build * @return Build
*/ */
public static function getBuild(Build $build, $type = null) public static function getBuild(Build $build)
{ {
if (is_null($type) && !is_null($build->getProject())) { $project = $build->getProject();
$type = $build->getProject()->getType();
}
switch ($type) { if (!empty($project)) {
switch ($project->getType()) {
case 'remote': case 'remote':
$type = 'RemoteGitBuild'; $type = 'RemoteGitBuild';
break; break;
@ -68,14 +66,10 @@ class BuildFactory
case 'svn': case 'svn':
$type = 'SubversionBuild'; $type = 'SubversionBuild';
break; break;
default:
$type = null;
break;
} }
if (!is_null($type)) { $class = '\\PHPCI\\Model\\Build\\' . $type;
$type = '\\PHPCI\\Model\\Build\\' . $type; $build = new $class($build->getDataArray());
$build = new $type($build->getDataArray());
} }
return $build; return $build;

2
PHPCI/Service/BuildService.php
View file

@ -87,7 +87,7 @@ class BuildService
$build = $this->buildStore->save($build); $build = $this->buildStore->save($build);
$build = BuildFactory::getBuild($build, $project->getType()); $build = BuildFactory::getBuild($build);
$build->sendStatusPostback(); $build->sendStatusPostback();
$this->addBuildToQueue($build); $this->addBuildToQueue($build);