Fixing tests

This commit is contained in:
Dan Cryer 2015-11-12 14:51:22 +00:00
parent 6a1b23bbb4
commit 29a6c9767a
6 changed files with 11 additions and 11 deletions

View file

@ -49,7 +49,7 @@ class ExecutorTest extends \PHPUnit_Framework_TestCase
->shouldBeCalledTimes(1)
->willReturn($this->prophesize('PHPCI\Plugin')->reveal());
$this->testedExecutor->executePlugin($pluginName, $options);
$this->testedExecutor->executePlugin($pluginName, $options, 'test');
}
public function testExecutePlugin_KeepsCalledNameSpace()
@ -61,7 +61,7 @@ class ExecutorTest extends \PHPUnit_Framework_TestCase
->shouldBeCalledTimes(1)
->willReturn($this->prophesize('PHPCI\Plugin')->reveal());
$this->testedExecutor->executePlugin($pluginClass, $options);
$this->testedExecutor->executePlugin($pluginClass, $options, 'test');
}
public function testExecutePlugin_CallsExecuteOnFactoryBuildPlugin()
@ -76,7 +76,7 @@ class ExecutorTest extends \PHPUnit_Framework_TestCase
$this->mockFactory->buildPlugin(Argument::any(), Argument::any())->willReturn($mockPlugin->reveal());
$this->mockFactory->getResourceFor('PHPCI\Model\Build')->willReturn($build);
$this->testedExecutor->executePlugin($pluginName, $options);
$this->testedExecutor->executePlugin($pluginName, $options, 'test');
}
public function testExecutePlugin_ReturnsPluginSuccess()
@ -91,7 +91,7 @@ class ExecutorTest extends \PHPUnit_Framework_TestCase
$this->mockFactory->buildPlugin(Argument::any(), Argument::any())->willReturn($mockPlugin->reveal());
$returnValue = $this->testedExecutor->executePlugin($pluginName, $options);
$returnValue = $this->testedExecutor->executePlugin($pluginName, $options, 'test');
$this->assertEquals($expectedReturnValue, $returnValue);
}
@ -103,7 +103,7 @@ class ExecutorTest extends \PHPUnit_Framework_TestCase
$this->mockBuildLogger->logFailure('Plugin does not exist: ' . $pluginName)->shouldBeCalledTimes(1);
$this->testedExecutor->executePlugin($pluginName, $options);
$this->testedExecutor->executePlugin($pluginName, $options, 'test');
}
public function testExecutePlugin_LogsFailureWhenExceptionsAreThrownByPlugin()
@ -121,7 +121,7 @@ class ExecutorTest extends \PHPUnit_Framework_TestCase
$this->mockBuildLogger->logFailure('Exception: ' . $expectedException->getMessage(), $expectedException)
->shouldBeCalledTimes(1);
$this->testedExecutor->executePlugin($pluginName, $options);
$this->testedExecutor->executePlugin($pluginName, $options, 'test');
}
public function testExecutePlugins_CallsEachPluginForStage()

View file

@ -14,7 +14,7 @@ use PHPCI\Builder;
use PHPCI\Model\Build;
use PHPCI\Plugin;
class ExamplePluginFull implements Plugin {
class ExamplePluginFull extends Plugin\AbstractPlugin {
/**
* @var array
*/

View file

@ -12,7 +12,7 @@ namespace Tests\PHPCI\Plugin\Util\Fake;
use PHPCI\Plugin;
class ExamplePluginWithNoConstructorArgs implements Plugin
class ExamplePluginWithNoConstructorArgs extends Plugin\AbstractPlugin
{
public function execute()
{

View file

@ -12,7 +12,7 @@ namespace Tests\PHPCI\Plugin\Util\Fake;
use PHPCI\Plugin;
class ExamplePluginWithSingleOptionalArg implements Plugin
class ExamplePluginWithSingleOptionalArg extends Plugin\AbstractPlugin
{
function __construct($optional = null)
{

View file

@ -12,7 +12,7 @@ namespace Tests\PHPCI\Plugin\Util\Fake;
use PHPCI\Plugin;
class ExamplePluginWithSingleRequiredArg implements Plugin
class ExamplePluginWithSingleRequiredArg extends Plugin\AbstractPlugin
{
public $RequiredArgument;

View file

@ -12,7 +12,7 @@ namespace Tests\PHPCI\Plugin\Util\Fake;
use PHPCI\Plugin;
class ExamplePluginWithSingleTypedRequiredArg implements Plugin
class ExamplePluginWithSingleTypedRequiredArg extends Plugin\AbstractPlugin
{
public $RequiredArgument;