From 6b015d31065e2d5e9565012a298f2b14fe57eff3 Mon Sep 17 00:00:00 2001
From: born_free <b0rn@list.ru>
Date: Sat, 2 Nov 2013 16:39:55 -0700
Subject: [PATCH] fixed XSS in user name and project name properties

---
 PHPCI/View/Build/view.phtml   | 2 +-
 PHPCI/View/BuildsTable.phtml  | 2 +-
 PHPCI/View/Home/index.phtml   | 2 +-
 PHPCI/View/Project/view.phtml | 4 ++--
 PHPCI/View/SummaryTable.phtml | 2 +-
 PHPCI/View/User/index.phtml   | 2 +-
 PHPCI/View/UserForm.phtml     | 2 +-
 PHPCI/View/layout.phtml       | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/PHPCI/View/Build/view.phtml b/PHPCI/View/Build/view.phtml
index a9cd569a..aa18e591 100644
--- a/PHPCI/View/Build/view.phtml
+++ b/PHPCI/View/Build/view.phtml
@@ -7,7 +7,7 @@
 	<div class="col-lg-3">
         <ul class="nav nav-pills nav-stacked">
 			<li><a href="<?= PHPCI_URL ?>"><i class="icon-home"></i> Dashboard</a></li>
-			<li><a href="<?= PHPCI_URL ?>project/view/<?php print $build->getProject()->getId(); ?>"><i class="icon-folder-open"></i> <?php print $build->getProject()->getTitle(); ?></a></li>
+			<li><a href="<?= PHPCI_URL ?>project/view/<?php print $build->getProject()->getId(); ?>"><i class="icon-folder-open"></i> <?php print htmlspecialchars($build->getProject()->getTitle()); ?></a></li>
 		</ul>
 			<h5>Options</h5>
         <ul class="nav nav-pills nav-stacked">
diff --git a/PHPCI/View/BuildsTable.phtml b/PHPCI/View/BuildsTable.phtml
index 6d72c9a2..e38d8580 100644
--- a/PHPCI/View/BuildsTable.phtml
+++ b/PHPCI/View/BuildsTable.phtml
@@ -41,7 +41,7 @@ switch($build->getStatus())
 	<td><a href="<?= PHPCI_URL ?>project/view/<?php print $build->getProjectId(); ?>">
         <?php
             if (is_object($build->getProject())) {
-                print $build->getProject()->getTitle();
+                print htmlspecialchars($build->getProject()->getTitle());
             } else {
                 print ' - ';
             }
diff --git a/PHPCI/View/Home/index.phtml b/PHPCI/View/Home/index.phtml
index d372786d..68a0f26f 100644
--- a/PHPCI/View/Home/index.phtml
+++ b/PHPCI/View/Home/index.phtml
@@ -11,7 +11,7 @@
         <h5>Projects</h5>
         <ul class="nav nav-pills nav-stacked">
 			<?php foreach($projects as $project): ?>
-			<li><a href="<?= PHPCI_URL ?>project/view/<?php print $project->getId(); ?>"><?php print $project->getTitle(); ?></a></li>
+			<li><a href="<?= PHPCI_URL ?>project/view/<?php print $project->getId(); ?>"><?php print htmlspecialchars($project->getTitle()); ?></a></li>
 			<?php endforeach; ?>
 		</ul>
         <?php endif; ?>
diff --git a/PHPCI/View/Project/view.phtml b/PHPCI/View/Project/view.phtml
index bb3566f6..762e476a 100644
--- a/PHPCI/View/Project/view.phtml
+++ b/PHPCI/View/Project/view.phtml
@@ -1,12 +1,12 @@
 <div id="title">
-	<h1>Project: <?php print (is_object($project)) ? $project->getTitle() : ' - '; ?></h1>
+	<h1>Project: <?php print (is_object($project)) ? htmlspecialchars($project->getTitle()) : ' - '; ?></h1>
 </div>
 
 <div class="row">
 	<div class="col-lg-3">
         <ul class="nav nav-pills nav-stacked">
 			<li><a href="<?= PHPCI_URL ?>"><i class="icon-home"></i> Dashboard</a></li>
-			<li><a href="<?= PHPCI_URL ?>project/view/<?php print $project->getId(); ?>"><i class="icon-folder-open"></i> <?php print $project->getTitle(); ?></a></li>
+			<li><a href="<?= PHPCI_URL ?>project/view/<?php print $project->getId(); ?>"><i class="icon-folder-open"></i> <?php print htmlspecialchars($project->getTitle()); ?></a></li>
 		</ul>
 			<h5>Options</h5>
         <ul class="nav nav-pills nav-stacked">
diff --git a/PHPCI/View/SummaryTable.phtml b/PHPCI/View/SummaryTable.phtml
index 087b5cef..7f0988b6 100644
--- a/PHPCI/View/SummaryTable.phtml
+++ b/PHPCI/View/SummaryTable.phtml
@@ -82,7 +82,7 @@ foreach($projects as $project):
             <?= $health ?>
         </span>
     </td>
-    <td><a href='<?= PHPCI_URL ?>project/view/<?= $project->getId() ?>'><?= $project->getTitle() ?></a></td>
+    <td><a href='<?= PHPCI_URL ?>project/view/<?= $project->getId() ?>'><?= htmlspecialchars($project->getTitle()) ?></a></td>
     <td><?php print is_null($success) ? 'Never' : $success; ?></td>
     <td><?php print is_null($failure) ? 'Never' : $failure; ?></td>
     <td>
diff --git a/PHPCI/View/User/index.phtml b/PHPCI/View/User/index.phtml
index 147c6ea6..bcdcb7f1 100644
--- a/PHPCI/View/User/index.phtml
+++ b/PHPCI/View/User/index.phtml
@@ -40,7 +40,7 @@
 				?>
 				<tr class="<?php print $cls; ?>">
 					<td><a href="<?= PHPCI_URL ?>user/edit/<?php print $user->getId(); ?>"><?php print $user->getEmail(); ?></a></td>
-					<td><?php print $user->getName(); ?></td>
+					<td><?php print htmlspecialchars($user->getName()); ?></td>
 					<td><?php print $status; ?></td>
 					<td>
 						<?php if($this->User()->getIsAdmin()): ?>
diff --git a/PHPCI/View/UserForm.phtml b/PHPCI/View/UserForm.phtml
index 40ddcc19..23b0a737 100644
--- a/PHPCI/View/UserForm.phtml
+++ b/PHPCI/View/UserForm.phtml
@@ -1,5 +1,5 @@
 <div id="title">
-	<h1><?php print $type == 'add' ? 'Add User' : 'Edit ' . $user->getName() ?></h1>
+	<h1><?php print $type == 'add' ? 'Add User' : 'Edit ' . htmlspecialchars($user->getName()) ?></h1>
 </div>
 
 <div class="row">
diff --git a/PHPCI/View/layout.phtml b/PHPCI/View/layout.phtml
index 85313f1f..37729618 100644
--- a/PHPCI/View/layout.phtml
+++ b/PHPCI/View/layout.phtml
@@ -36,7 +36,7 @@
 
                 <div class="nav-collapse collapse navbar-responsive-collapse">
                     <ul class="nav navbar-nav pull-right">
-                        <li><p class="navbar-text"><strong><?php print $this->User()->getName(); ?></strong></p></li>
+                        <li><p class="navbar-text"><strong><?php print htmlspecialchars($this->User()->getName()); ?></strong></p></li>
                         <li><a href="<?php print PHPCI_URL ?>session/logout">Log out</a></li>
                         <?php if ($this->User()->getIsAdmin()): ?>
                         <li>