deblan/phpci
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

fixed not type checking status

Browse source
This commit is contained in:
Gabriel Baker 2013-05-13 21:33:59 +01:00
parent e0accc7a97
commit 53675c940f
2 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
PHPCI/Builder.php
View file

@ -143,7 +143,7 @@ class Builder
// Do an HTTP clone:
$this->executeCommand('git clone -b ' .$this->build->getBranch() . ' ' .$url.' '.$this->buildPath);
}
if(!is_file($this->buildPath . 'phpci.yml'))
{
$this->logFailure('Project does not contain a phpci.yml file.');
@ -202,7 +202,7 @@ class Builder
{
$this->success = false;
}
continue;
}
@ -216,7 +216,7 @@ class Builder
{
$this->success = false;
}
$this->logFailure('PLUGIN STATUS: FAILED');
continue;
}

26
PHPCI/Model/Base/BuildBase.php
View file

@ -143,7 +143,7 @@ class BuildBase extends Model
{
$rtn = $this->_data['id'];
return $rtn;
}
@ -151,7 +151,7 @@ class BuildBase extends Model
{
$rtn = $this->_data['project_id'];
return $rtn;
}
@ -159,7 +159,7 @@ class BuildBase extends Model
{
$rtn = $this->_data['commit_id'];
return $rtn;
}
@ -167,7 +167,7 @@ class BuildBase extends Model
{
$rtn = $this->_data['status'];
return $rtn;
}
@ -175,7 +175,7 @@ class BuildBase extends Model
{
$rtn = $this->_data['log'];
return $rtn;
}
@ -183,7 +183,7 @@ class BuildBase extends Model
{
$rtn = $this->_data['branch'];
return $rtn;
}
@ -191,13 +191,13 @@ class BuildBase extends Model
{
$rtn = $this->_data['created'];
if(!empty($rtn))
{
$rtn = new \DateTime($rtn);
}
return $rtn;
}
@ -205,13 +205,13 @@ class BuildBase extends Model
{
$rtn = $this->_data['started'];
if(!empty($rtn))
{
$rtn = new \DateTime($rtn);
}
return $rtn;
}
@ -219,13 +219,13 @@ class BuildBase extends Model
{
$rtn = $this->_data['finished'];
if(!empty($rtn))
{
$rtn = new \DateTime($rtn);
}
return $rtn;
}
@ -277,7 +277,7 @@ class BuildBase extends Model
{
$this->_validateNotNull('Status', $value);
$this->_validateInt('Status', $value);
if($this->_data['status'] == $value)
if($this->_data['status'] === $value)
{
return;
}