Support local PHPMD rules and suffixes
Allows to specify rules as a relative path in the project. The suffixes to scan can be given in options now, default is just php.
This commit is contained in:
parent
0caa1605d6
commit
5f2b5fc2e7
|
@ -17,31 +17,57 @@ namespace PHPCI\Plugin;
|
||||||
*/
|
*/
|
||||||
class PhpMessDetector implements \PHPCI\Plugin
|
class PhpMessDetector implements \PHPCI\Plugin
|
||||||
{
|
{
|
||||||
protected $directory;
|
|
||||||
/**
|
/**
|
||||||
* Array of PHPMD rules. Possible values: codesize, unusedcode, naming, design, controversial
|
* @var \PHPCI\Builder
|
||||||
|
*/
|
||||||
|
protected $phpci;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @var array
|
||||||
|
*/
|
||||||
|
protected $suffixes;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Array of PHPMD rules. Can be one of the builtins (codesize, unusedcode, naming, design, controversial)
|
||||||
|
* or a filenname (detected by checking for a / in it), either absolute or relative to the project root.
|
||||||
* @var array
|
* @var array
|
||||||
*/
|
*/
|
||||||
protected $rules;
|
protected $rules;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param \PHPCI\Builder $phpci
|
||||||
|
* @param array $options
|
||||||
|
*/
|
||||||
public function __construct(\PHPCI\Builder $phpci, array $options = array())
|
public function __construct(\PHPCI\Builder $phpci, array $options = array())
|
||||||
{
|
{
|
||||||
$this->phpci = $phpci;
|
$this->phpci = $phpci;
|
||||||
$this->rules = isset($options['rules']) ? (array)$options['rules'] : array('codesize', 'unusedcode', 'naming');
|
|
||||||
|
$this->suffixes = isset($options['suffixes']) ? (array)$options['suffixes'] : array('php');
|
||||||
|
|
||||||
|
$this->rules = isset($options['rules']) ? (array)$options['rules'] : array('codesize', 'unusedcode', 'naming');
|
||||||
|
foreach ($this->rules as &$rule) {
|
||||||
|
if ($rule[0] !== '/' && strpos($rule, '/') !== FALSE) {
|
||||||
|
$rule = $this->phpci->buildPath . $rule;
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Runs PHP Mess Detector in a specified directory.
|
* Runs PHP Mess Detector in a specified directory.
|
||||||
*/
|
*/
|
||||||
public function execute()
|
public function execute()
|
||||||
{
|
{
|
||||||
$ignore = '';
|
$ignore = '';
|
||||||
|
|
||||||
if (count($this->phpci->ignore)) {
|
if (count($this->phpci->ignore)) {
|
||||||
$ignore = ' --exclude ' . implode(',', $this->phpci->ignore);
|
$ignore = ' --exclude ' . implode(',', $this->phpci->ignore);
|
||||||
}
|
}
|
||||||
|
|
||||||
$cmd = PHPCI_BIN_DIR . 'phpmd "%s" text %s %s';
|
$suffixes = '';
|
||||||
return $this->phpci->executeCommand($cmd, $this->phpci->buildPath, implode(',', $this->rules), $ignore);
|
if (count($this->suffixes)) {
|
||||||
|
$suffixes = ' --suffixes ' . implode(',', $this->suffixes);
|
||||||
|
}
|
||||||
|
|
||||||
|
$cmd = PHPCI_BIN_DIR . 'phpmd "%s" text %s %s %s';
|
||||||
|
return $this->phpci->executeCommand($cmd, $this->phpci->buildPath, implode(',', $this->rules), $ignore, $suffixes);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue