From d46ea12dd73e3a84e8422045c22da3d87bc3e643 Mon Sep 17 00:00:00 2001 From: Dan Cryer Date: Thu, 10 Oct 2013 01:26:06 +0100 Subject: [PATCH] Fixing summary table so it doesn't completely die when there is a running build. --- PHPCI/Model/Build/GithubBuild.php | 2 +- PHPCI/View/SummaryTable.phtml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PHPCI/Model/Build/GithubBuild.php b/PHPCI/Model/Build/GithubBuild.php index 24ea63f7..f208c568 100644 --- a/PHPCI/Model/Build/GithubBuild.php +++ b/PHPCI/Model/Build/GithubBuild.php @@ -78,7 +78,7 @@ class GithubBuild extends RemoteGitBuild $http->setHeaders($headers); $res = $http->request('POST', $url, json_encode($params)); - + } /** diff --git a/PHPCI/View/SummaryTable.phtml b/PHPCI/View/SummaryTable.phtml index 3d31ac09..087b5cef 100644 --- a/PHPCI/View/SummaryTable.phtml +++ b/PHPCI/View/SummaryTable.phtml @@ -53,12 +53,12 @@ foreach($projects as $project): case 2: $successes++; $statuses[] = 'ok'; - $success = is_null($success) ? $build->getFinished()->format('Y-m-d H:i:s') : $success; + $success = is_null($success) && !is_null($build->getFinished()) ? $build->getFinished()->format('Y-m-d H:i:s') : $success; break; case 3: $failures++; $statuses[] = 'failed'; - $failure = is_null($failure) ? $build->getFinished()->format('Y-m-d H:i:s') : $failure; + $failure = is_null($failure) && !is_null($build->getFinished()) ? $build->getFinished()->format('Y-m-d H:i:s') : $failure; break; } }