deblan/phpci
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Removing success field from Builder as it is only used in one method, see #382

Browse source
This commit is contained in:
Dan Cryer 2014-05-02 14:58:21 +00:00
parent 128bfb4a94
commit d98e85ffc3
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
PHPCI/Builder.php
View file

@ -47,11 +47,6 @@ class Builder implements LoggerAwareInterface
*/
protected $directory;
/**
* @var bool
*/
protected $success = true;
/**
* @var bool
*/
@ -192,7 +187,7 @@ class Builder implements LoggerAwareInterface
$this->build->setStarted(new \DateTime());
$this->store->save($this->build);
$this->build->sendStatusPostback();
$this->success = true;
$success = true;
try {
// Set up the build:
@ -200,12 +195,12 @@ class Builder implements LoggerAwareInterface
// Run the core plugin stages:
foreach (array('setup', 'test') as $stage) {
$this->success &= $this->pluginExecutor->executePlugins($this->config, $stage);
$success &= $this->pluginExecutor->executePlugins($this->config, $stage);
}
// Set the status so this can be used by complete, success and failure
// stages.
if ($this->success) {
if ($success) {
$this->build->setStatus(Build::STATUS_SUCCESS);
} else {
$this->build->setStatus(Build::STATUS_FAILED);
@ -214,7 +209,7 @@ class Builder implements LoggerAwareInterface
// Complete stage plugins are always run
$this->pluginExecutor->executePlugins($this->config, 'complete');
if ($this->success) {
if ($success) {
$this->pluginExecutor->executePlugins($this->config, 'success');
$this->buildLogger->logSuccess('BUILD SUCCESSFUL!');
} else {