From db93f5542770938e2a7b08747ec5a1d76c5a8f67 Mon Sep 17 00:00:00 2001 From: David Rimbault Date: Wed, 27 Apr 2016 17:59:29 +0200 Subject: [PATCH] [FIX] Running Complete stage even on Exception catch. (#1186) --- PHPCI/Builder.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PHPCI/Builder.php b/PHPCI/Builder.php index 0edc44d8..1aed3d3f 100644 --- a/PHPCI/Builder.php +++ b/PHPCI/Builder.php @@ -213,8 +213,6 @@ class Builder implements LoggerAwareInterface $this->build->setStatus(Build::STATUS_FAILED); } - // Complete stage plugins are always run - $this->pluginExecutor->executePlugins($this->config, 'complete'); if ($success) { $this->pluginExecutor->executePlugins($this->config, 'success'); @@ -236,6 +234,9 @@ class Builder implements LoggerAwareInterface } catch (\Exception $ex) { $this->build->setStatus(Build::STATUS_FAILED); $this->buildLogger->logFailure(Lang::get('exception') . $ex->getMessage()); + }finally{ + // Complete stage plugins are always run + $this->pluginExecutor->executePlugins($this->config, 'complete'); }