From e810d2355f68a0b30fcce8e5594676d861507407 Mon Sep 17 00:00:00 2001 From: dancryer Date: Thu, 16 Oct 2014 07:19:31 -0700 Subject: [PATCH] Created Maintainers (markdown) --- Maintainers.md | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Maintainers.md diff --git a/Maintainers.md b/Maintainers.md new file mode 100644 index 0000000..c42d4a0 --- /dev/null +++ b/Maintainers.md @@ -0,0 +1,38 @@ +Maintainers help to keep the PHPCI project moving, they do this by helping to manage issues, merging pull requests, improving documentation and by contributing code to the project. + +The current team of maintainers are as follows: + +**Core Maintainers** + +* Dan (@dancryer) +* Steve (@meadsteve) + +**Maintainers** + +* Mike (@mikebronner) +* James (@jfi) +* Tobias (@tvbeek) + +## Guidelines for Maintainers + +### Merging Pull Requests + +It is the responsibility of the maintainers to merge pull requests, but only where they meet the contribution guidelines and pass our merging checklist. + +**The Checklist** + +1. Is the pull-request ready to be merged? + +_The maintainer should check that the author has fully completed the bug fix / feature / refactor before merging the pull request._ + +2. Has the author properly explained the intended purpose of their pull request, and detailed their changes? + +_Authors need to explain in clear, concise language, what their patch is intended to do. Where their implementation is large or in any way complex, the changes themselves should be documented at the code level._ + +3. Has the author provided documentation updates for any new or changed features? + +_The wiki should not be updated until the pull request is merged, but documentation updates should be detailed in the pull request itself._ + +4. Has the pull request passed PHPCI checks? + +_It goes without saying that the project master branch should always pass its own PHPCI tests. This means that the patch will need to be PSR-2 compliant, all classes and methods should have valid docblocks, and all tests should pass._ \ No newline at end of file