Browse Source

devops: fix headlessness reporting to flakiness dashboard (#14069)

pull/14072/head
Andrey Lushnikov 2 months ago committed by GitHub
parent
commit
ddcce7a63a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      CONTRIBUTING.md
  2. 2
      tests/library/playwright.config.ts

4
CONTRIBUTING.md

@ -171,7 +171,7 @@ it.skip('should work', async ({server, page}) => {
- To run tests in non-headless (headed) mode:
```bash
HEADFUL=1 npm run ctest
npm run ctest -- --headed
```
- To run tests with custom browser executable, specify `CRPATH`, `WKPATH` or `FFPATH` env variable that points to browser executable:
@ -183,7 +183,7 @@ CRPATH=<path-to-executable> npm run ctest
- To run tests in slow-mode:
```bash
HEADFUL=1 SLOW_MO=500 npm run wtest
SLOW_MO=500 npm run wtest -- --headed
```
- When should a test be marked with `skip` or `fail`?

2
tests/library/playwright.config.ts

@ -36,7 +36,7 @@ const getExecutablePath = (browserName: BrowserName) => {
const mode = process.env.PW_OUT_OF_PROCESS_DRIVER ?
'driver' :
(process.env.PWTEST_MODE || 'default') as ('default' | 'driver' | 'service' | 'service2');
const headed = !!process.env.HEADFUL;
const headed = process.argv.includes('--headed');
const channel = process.env.PWTEST_CHANNEL as any;
const video = !!process.env.PWTEST_VIDEO;
const trace = !!process.env.PWTEST_TRACE;

Loading…
Cancel
Save