You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 
Yury Semikhatsky 84a5400d0d
browser(webkit): ctrl+click on windows (#11667)
1 day ago
..
chromium browser(chromium): roll to r962349 (#11587) 4 days ago
ffmpeg devops: support --full flag for ffmpeg compilation (#11076) 1 month ago
firefox devops: attempt to build firefox without maintenanceservice.exe (#11663) 1 day ago
firefox-beta devops: attempt to build firefox without maintenanceservice.exe (#11663) 1 day ago
webkit browser(webkit): ctrl+click on windows (#11667) 1 day ago
winldd Revert "browser(winldd): attempt to fix dependency loading on windows (#7790)" (#7948) 6 months ago
README.md docs: bring browser_patches readme up-to-date 3 months ago
build.sh devops: fix `//browser_patches/{build.sh,clean.sh}` scripts (#9515) 4 months ago
checkout_build_archive_upload.sh devops: support --full flag for ffmpeg compilation (#11076) 1 month ago
clean.sh devops: fix `//browser_patches/{build.sh,clean.sh}` scripts (#9515) 4 months ago
export.sh devops: move Firefox and WebKit checkouts to $HOME (#9485) 4 months ago
prepare_checkout.sh devops: fix chromium checkout (#10288) 3 months ago
repack-juggler.mjs devops: fix repack_juggler script (#10864) 2 months ago
sanitize_and_compress_log.js devops: use node.js to gzip logs 2 years ago
send_telegram_message.sh chore: quote all bash variables when used (#8066) 6 months ago
upload.sh chore: quote all bash variables when used (#8066) 6 months ago
utils.sh devops: bundle vcruntime140_1.dll with Firefox builds (#10099) 3 months ago

README.md

Contributing Browser Patches

Firefox and WebKit have additional patches atop to expose necessary capabilities.

Ideally, all these changes should be upstreamed. For the time being, it is possible to setup a browser checkout and develop from there.

WebKit upstream status

1. Setting up local browser checkout

From the playwright repo, run the following command:

$ ./browser_patches/prepare_checkout.sh firefox

(you can optionally pass "webkit" for a webkit checkout)

This will create a firefox checkout at $HOME/firefox

NOTE: this command downloads GBs of data.

This command will:

  • create a browser_upstream remote in the checkout
  • create a playwright-build branch and apply all playwright-required patches to it.

2. Developing a new change

You want to create a new branch off the playwright-build branch.

Assuming that you're under $HOME/firefox checkout:

$ git checkout -b my-new-feature playwright-build
$ # develop my feature on the my-new-feature branch ....

3. Exporting your change to playwright repo

Once you're happy with the work you did in the browser-land, you want to export it to the playwright repo.

Assuming that you're in the root of the playwright repo and that your browser checkout has your feature branch checked out:

$ ./browser_patches/export.sh firefox

This script will:

  • create a new patch and put it to the ./browser_patches/firefox/patches/
  • update the ./browser_patches/firefox/UPSTREAM_CONFIG.sh if necessary
  • bump the ./browser_patches/firefox/BUILD_NUMBER number.

The script will assume Firefox checkout is located at $HOME/firefox

Send a PR to the Playwright repo to be reviewed.

4. Rolling Playwright to the new browser build

Once the patch has been committed, the build bots will kick in, compile and upload a new browser version to all the platforms. Then you can roll the browser:

$ node utils/roll_browser.js chromium 123456

Cheatsheet

See browser stdout/stderr

Set the DEBUG=pw:browser environment variable to see it.

Firefox

Debug build

When compiling set the FF_DEBUG_BUILD=1 environment variable.

Stack trace

In //mozglue/misc/StackWalk.cpp add

#define MOZ_DEMANGLE_SYMBOLS 1

In native code use

#include "mozilla/StackWalk.h"
// ...
MozWalkTheStack(stderr);

If the stack trace is still mangled cat it to tools/rb/fix_linux_stack.py

Logging

Upstream documentation: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Gecko_Logging

MOZ_LOG=nsHttp:5

Module name is a string passed to the mozilla::LazyLogModule of the corresponding component, e.g.:

LazyLogModule gHttpLog("nsHttp");

Inside Juggler, you can use dump('foo\n').

WebKit

Logging

Inside Objective-C you can use NSLog.

NSLog(@"Foobar value: %@", value);

Debugging windows

In Source\WTF\wtf\win\DbgHelperWin.cpp replace

#if !defined(NDEBUG) with #if 1

Then regular WTFReportBacktrace() works.

Enable core dumps on Linux

mkdir -p /tmp/coredumps
sudo bash -c 'echo "/tmp/coredumps/core-pid_%p.dump" > /proc/sys/kernel/core_pattern'
ulimit -c unlimited

Then to read stack traces run the following command:

# To find out crashing process name
file core-pid_29652.dump
# Point gdb to the local binary of the crashed process and the core file
gdb $HOME/.cache/ms-playwright/webkit-1292/minibrowser-gtk/WebKitWebProcess core-pid_29652
# Inside gdb update .so library search path to the local one
set solib-search-path /home/yurys/.cache/ms-playwright/webkit-1292/minibrowser-gtk
# Finally print backtrace
bt