deblan/propel-bundle
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #298 from havvg/1.4

Browse source 
fix AbstractCommandTest avoiding SplFileInfo mocks
This commit is contained in:
Toni Uebernickel 2014-11-01 15:58:51 +01:00
parent 68793ac525 5e8668a7e0
commit 5af07d37fc
3 changed files with 20 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Command/AbstractCommand.php
View file

@ -306,7 +306,9 @@ abstract class AbstractCommand extends ContainerAwareCommand
}
/**
* @param \Symfony\Component\HttpKernel\Bundle\BundleInterface
* @param \Symfony\Component\HttpKernel\Bundle\BundleInterface $bundle
*
* @return array
*/
protected function getSchemasFromBundle(BundleInterface $bundle)
{

43
Tests/Command/AbstractCommandTest.php
View file

@ -20,6 +20,9 @@ use Symfony\Component\HttpKernel\KernelInterface;
*/
class AbstractCommandTest extends TestCase
{
/**
* @var TestableAbstractCommand
*/
protected $command;
public function setUp()
@ -40,6 +43,9 @@ class AbstractCommandTest extends TestCase
public function testTransformToLogicalName()
{
$bundleDir = realpath(__DIR__ . '/../Fixtures/src/My/SuperBundle');
$filename = 'Resources' . DIRECTORY_SEPARATOR . 'config' . DIRECTORY_SEPARATOR . 'a-schema.xml';
$bundle = $this->getMock('Symfony\Component\HttpKernel\Bundle\BundleInterface');
$bundle
->expects($this->once())
@ -48,47 +54,30 @@ class AbstractCommandTest extends TestCase
$bundle
->expects($this->once())
->method('getPath')
->will($this->returnValue('/Users/foo/project/src/My/SuperBundle'));
$schema = $this
->getMockBuilder('\SplFileInfo')
->disableOriginalConstructor()
->getMock();
$schema
->expects($this->once())
->method('getRealPath')
->will($this->returnValue('/Users/foo/project/src/My/SuperBundle'
. DIRECTORY_SEPARATOR . 'Resources' . DIRECTORY_SEPARATOR . 'config' . DIRECTORY_SEPARATOR . 'my-schema.xml'));
$expected = '@MySuperBundle/Resources/config/my-schema.xml';
->will($this->returnValue($bundleDir));
$schema = new \SplFileInfo($bundleDir . DIRECTORY_SEPARATOR . $filename);
$expected = '@MySuperBundle/Resources/config/a-schema.xml';
$this->assertEquals($expected, $this->command->transformToLogicalName($schema, $bundle));
}
public function testTransformToLogicalNameWithSubDir()
{
$bundleDir = realpath(__DIR__ . '/../Fixtures/src/My/ThirdBundle');
$filename = 'Resources' . DIRECTORY_SEPARATOR . 'config' . DIRECTORY_SEPARATOR . 'propel' . DIRECTORY_SEPARATOR . 'schema.xml';
$bundle = $this->getMock('Symfony\Component\HttpKernel\Bundle\BundleInterface');
$bundle
->expects($this->once())
->method('getName')
->will($this->returnValue('MySuperBundle'));
->will($this->returnValue('MyThirdBundle'));
$bundle
->expects($this->once())
->method('getPath')
->will($this->returnValue('/Users/foo/project/src/My/SuperBundle'));
$schema = $this
->getMockBuilder('\SplFileInfo')
->disableOriginalConstructor()
->getMock();
$schema
->expects($this->once())
->method('getRealPath')
->will($this->returnValue('/Users/foo/project/src/My/SuperBundle'
. DIRECTORY_SEPARATOR . 'Resources' . DIRECTORY_SEPARATOR . 'config' . DIRECTORY_SEPARATOR . 'propel/my-schema.xml'));
$expected = '@MySuperBundle/Resources/config/propel/my-schema.xml';
->will($this->returnValue($bundleDir));
$schema = new \SplFileInfo($bundleDir . DIRECTORY_SEPARATOR . $filename);
$expected = '@MyThirdBundle/Resources/config/propel/schema.xml';
$this->assertEquals($expected, $this->command->transformToLogicalName($schema, $bundle));
}

1
Tests/Fixtures/src/My/ThirdBundle/Resources/config/propel/schema.xml Normal file
View file

@ -0,0 +1 @@
This is a schema.xml