From ab8b7454967ba91b560dc123470e88a0ae638ec4 Mon Sep 17 00:00:00 2001 From: Simon Vieille Date: Sat, 21 Jan 2023 21:41:16 +0100 Subject: [PATCH 1/2] add check if menu exists before adding event listeners (#210) --- templates/js/script.php | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/templates/js/script.php b/templates/js/script.php index f62b7da..ace79ac 100644 --- a/templates/js/script.php +++ b/templates/js/script.php @@ -96,6 +96,10 @@ if ($_['always-displayed']) { const headerMenuOpener = querySelector('#header .side-menu-opener') const sideMenuOpener = querySelectorAll('#side-menu .side-menu-opener') + if (!headerMenuOpener) { + return + } + sideMenuFocus = () => { let a = querySelector('.side-menu-app.active a', sideMenu) @@ -197,11 +201,13 @@ if ($_['always-displayed']) { - - nextcloud.parentNode.insertBefore(sideMenuOpener, nextcloud) - - nextcloud.parentNode.insertBefore(sideMenuOpener, nextcloud.nextSibling) - + if (nextcloud) { + + nextcloud.parentNode.insertBefore(sideMenuOpener, nextcloud) + + nextcloud.parentNode.insertBefore(sideMenuOpener, nextcloud.nextSibling) + + } const topMenuApps = From ddcd10f7b09b1cdee27711eb93e577e363d3447b Mon Sep 17 00:00:00 2001 From: Simon Vieille Date: Sat, 21 Jan 2023 21:45:41 +0100 Subject: [PATCH 2/2] release v2.5.2 --- CHANGELOG.md | 5 ++++- appinfo/info.xml | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5a79237..39779b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,10 +1,13 @@ ## [Unreleased] +## 2.5.2 +### Fixed +* add check if menu exists before adding event listeners (#210) + ## 2.5.1 ### Fixed * fix icon render (#133) - ## 2.5.0 ### Changed * upgrade dependencies diff --git a/appinfo/info.xml b/appinfo/info.xml index f4c1969..a89d87f 100644 --- a/appinfo/info.xml +++ b/appinfo/info.xml @@ -26,7 +26,7 @@ If you like this application and if you want to support the development: * [Donate with liberapay](https://liberapay.com/deblan) * [Leave a comment](https://apps.nextcloud.com/apps/side_menu#comments) ]]> - 2.5.1 + 2.5.2 agpl Simon Vieille SideMenu