From 7b8d8800fccccaf0039658dec482e710237764a2 Mon Sep 17 00:00:00 2001
From: Simon Vieille <simon@deblan.fr>
Date: Sun, 21 Aug 2022 13:49:20 +0200
Subject: [PATCH] (cq) replace repeated strings with variables

---
 templates/settings/admin-form.php    | 28 +++++++++++++++-------------
 templates/settings/personal-form.php |  8 +++++---
 2 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/templates/settings/admin-form.php b/templates/settings/admin-form.php
index 59a5143..bd01e59 100644
--- a/templates/settings/admin-form.php
+++ b/templates/settings/admin-form.php
@@ -39,6 +39,8 @@ $choicesSizes = [
     'Big' => 'big',
 ];
 
+$labelShowHideApps = 'Show and hide the list of applications';
+$labelReset = 'Reset to default';
 ?>
 <div id="side-menu-section">
     <div class="section">
@@ -67,7 +69,7 @@ $choicesSizes = [
                         class="side-menu-setting side-menu-setting-live"
                         value="<?php print_unescaped($_['background-color-to']); ?>">
 
-                        <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t('Reset to default')); ?>" data-reset="<?php echo htmlentities(json_encode([
+                        <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t($labelReset)); ?>" data-reset="<?php echo htmlentities(json_encode([
                             'side-menu-background-color' => $_['defaults']['background-color'],
                             'side-menu-background-color-to' => $_['defaults']['background-color-to'],
                         ])) ?>"></div>
@@ -107,7 +109,7 @@ $choicesSizes = [
                         class="side-menu-setting side-menu-setting-live"
                         value="<?php print_unescaped($_['current-app-background-color']); ?>">
 
-                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t('Reset to default')); ?>" data-reset="<?php echo htmlentities(json_encode([
+                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t($labelReset)); ?>" data-reset="<?php echo htmlentities(json_encode([
                         'side-menu-current-app-background-color' => $_['defaults']['current-app-background-color'],
                     ])) ?>"></div>
                 </div>
@@ -127,7 +129,7 @@ $choicesSizes = [
                         class="side-menu-setting side-menu-setting-live"
                         value="<?php print_unescaped($_['text-color']); ?>">
 
-                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t('Reset to default')); ?>" data-reset="<?php echo htmlentities(json_encode([
+                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t($labelReset)); ?>" data-reset="<?php echo htmlentities(json_encode([
                         'side-menu-text-color' => $_['defaults']['text-color'],
                     ])) ?>"></div>
                 </div>
@@ -147,7 +149,7 @@ $choicesSizes = [
                         class="side-menu-setting"
                         value="<?php print_unescaped($_['loader-color']); ?>">
 
-                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t('Reset to default')); ?>" data-reset="<?php echo htmlentities(json_encode([
+                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t($labelReset)); ?>" data-reset="<?php echo htmlentities(json_encode([
                         'side-menu-loader-color' => $_['defaults']['loader-color'],
                     ])) ?>"></div>
                 </div>
@@ -255,7 +257,7 @@ $choicesSizes = [
                         class="side-menu-setting"
                         value="<?php print_unescaped($_['dark-mode-background-color-to']); ?>">
 
-                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t('Reset to default')); ?>" data-reset="<?php echo htmlentities(json_encode([
+                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t($labelReset)); ?>" data-reset="<?php echo htmlentities(json_encode([
                         'side-menu-dark-mode-background-color' => $_['defaults']['dark-mode-background-color'],
                         'side-menu-dark-mode-background-color-to' => $_['defaults']['dark-mode-background-color-to'],
                     ])) ?>"></div>
@@ -295,7 +297,7 @@ $choicesSizes = [
                         class="side-menu-setting"
                         value="<?php print_unescaped($_['dark-mode-current-app-background-color']); ?>">
 
-                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t('Reset to default')); ?>" data-reset="<?php echo htmlentities(json_encode([
+                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t($labelReset)); ?>" data-reset="<?php echo htmlentities(json_encode([
                         'side-menu-dark-mode-current-app-background-color' => $_['defaults']['dark-mode-current-app-background-color'],
                     ])) ?>"></div>
                 </div>
@@ -315,7 +317,7 @@ $choicesSizes = [
                         class="side-menu-setting"
                         value="<?php print_unescaped($_['dark-mode-text-color']); ?>">
 
-                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t('Reset to default')); ?>" data-reset="<?php echo htmlentities(json_encode([
+                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t($labelReset)); ?>" data-reset="<?php echo htmlentities(json_encode([
                         'side-menu-dark-mode-text-color' => $_['defaults']['dark-mode-text-color'],
                     ])) ?>"></div>
                 </div>
@@ -335,7 +337,7 @@ $choicesSizes = [
                         class="side-menu-setting"
                         value="<?php print_unescaped($_['dark-mode-loader-color']); ?>">
 
-                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t('Reset to default')); ?>" data-reset="<?php echo htmlentities(json_encode([
+                    <div class="theme-undo icon icon-history btn-reset" data-toggle="tooltip" data-original-title="<?php echo p($l->t($labelReset)); ?>" data-reset="<?php echo htmlentities(json_encode([
                         'side-menu-dark-mode-loader-color' => $_['defaults']['dark-mode-loader-color'],
                     ])) ?>"></div>
                 </div>
@@ -649,7 +651,7 @@ $choicesSizes = [
                 </div>
                 <div class="side-menu-setting-form">
                     <a class="side-menu-toggler" data-target="#big-menu-hidden-apps" href="#_">
-                        🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                        🖱️ <?php p($l->t($labelShowHideApps)); ?>
                     </a>
 
                     <div class="side-menu-setting" data-name="big-menu-hidden-apps" id="big-menu-hidden-apps" data-checkbox style="display: none">
@@ -718,7 +720,7 @@ $choicesSizes = [
                 </div>
                 <div class="side-menu-setting-form">
                     <a class="side-menu-toggler" data-target="#target-blank-apps" href="#_">
-                        🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                        🖱️ <?php p($l->t($labelShowHideApps)); ?>
                     </a>
 
                     <div class="side-menu-setting" data-name="target-blank-apps" id="target-blank-apps" data-checkbox style="display: none">
@@ -772,7 +774,7 @@ $choicesSizes = [
                 </div>
                 <div class="side-menu-setting-form">
                     <a class="side-menu-toggler" data-target="#top-menu-apps" href="#_">
-                        🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                        🖱️ <?php p($l->t($labelShowHideApps)); ?>
                     </a>
 
                     <div class="side-menu-setting" data-name="top-menu-apps" id="top-menu-apps" data-checkbox style="display: none">
@@ -805,7 +807,7 @@ $choicesSizes = [
                 </div>
                 <div class="side-menu-setting-form">
                     <a class="side-menu-toggler" data-target="#top-side-menu-apps" href="#_">
-                        🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                        🖱️ <?php p($l->t($labelShowHideApps)); ?>
                     </a>
 
                     <div class="side-menu-setting" data-name="top-side-menu-apps" id="top-side-menu-apps" data-checkbox style="display: none">
@@ -878,7 +880,7 @@ $choicesSizes = [
                 </div>
                 <div class="side-menu-setting-form">
                     <a class="side-menu-toggler" data-target="#apps-categories-custom-list" href="#_">
-                        🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                        🖱️ <?php p($l->t($labelShowHideApps)); ?>
                     </a>
 
                     <div id="apps-categories-custom-list" style="display: none">
diff --git a/templates/settings/personal-form.php b/templates/settings/personal-form.php
index ada1754..9e9bfc9 100644
--- a/templates/settings/personal-form.php
+++ b/templates/settings/personal-form.php
@@ -25,6 +25,8 @@ $choicesYesNo = [
     'Yes' => '1',
 ];
 
+
+$labelShowHideApps = 'Show and hide the list of applications';
 ?>
 <div id="side-menu-section">
     <?php if ($_['force']): ?>
@@ -85,7 +87,7 @@ $choicesYesNo = [
 
                         <p>
                             <a class="side-menu-toggler" data-target="#target-blank-apps" href="#_">
-                                🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                                🖱️ <?php p($l->t($labelShowHideApps)); ?>
                             </a>
                         </p>
 
@@ -131,7 +133,7 @@ $choicesYesNo = [
                     <div class="side-menu-setting-form">
                         <p>
                             <a class="side-menu-toggler" data-target="#top-menu-apps" href="#_">
-                                🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                                🖱️ <?php p($l->t($labelShowHideApps)); ?>
                             </a>
                         </p>
 
@@ -171,7 +173,7 @@ $choicesYesNo = [
                     <div class="side-menu-setting-form">
                         <p>
                             <a class="side-menu-toggler" data-target="#top-side-menu-apps" href="#_">
-                                🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                                🖱️ <?php p($l->t($labelShowHideApps)); ?>
                             </a>
                         </p>