diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4007b68..25ed1b1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
## [Unreleased]
+## 2.3.4
+### Fixed
+* fix blank line when settings are open (#96)
+
## 2.3.3
### Added
* hide the scrollbar when mouse is out (menu always displayed)
diff --git a/appinfo/info.xml b/appinfo/info.xml
index 232d990..4d57236 100644
--- a/appinfo/info.xml
+++ b/appinfo/info.xml
@@ -26,7 +26,7 @@ If you like this application and if you want to support the development:
* [Donate with liberapay](https://liberapay.com/deblan)
* [Leave a comment](https://apps.nextcloud.com/apps/side_menu#comments)
]]>
- 2.3.3
+ 2.3.4
agpl
Simon Vieille
SideMenu
diff --git a/css/sideMenu.css b/css/sideMenu.css
index 4de43d4..86436cb 100644
--- a/css/sideMenu.css
+++ b/css/sideMenu.css
@@ -298,6 +298,10 @@
padding: 10px 0;
}
+.side-menu-always-displayed #body-settings, #body-settings.body-settings-side-menu {
+ overflow-x: visible;
+}
+
@media screen and (max-width: 1024px) {
#side-menu.side-menu-big {
max-width: 290px;
diff --git a/package.json b/package.json
index f38078f..cf982d8 100644
--- a/package.json
+++ b/package.json
@@ -21,7 +21,7 @@
"extends @nextcloud/browserslist-config"
],
"engines": {
- "node": ">=10.0.0"
+ "node": ">=16.0.0"
},
"devDependencies": {
"@babel/core": "^7.9.0",
@@ -43,9 +43,9 @@
"eslint-plugin-standard": "^4.0.1",
"eslint-plugin-vue": "^5.2.3",
"file-loader": "^6.0.0",
- "node-sass": "^4.13.1",
"sass-loader": "^8.0.2",
"stylelint": "^8.4.0",
+ "sass": "^1.49.9",
"stylelint-config-recommended-scss": "^3.3.0",
"stylelint-scss": "^3.16.0",
"stylelint-webpack-plugin": "^0.10.5",
diff --git a/templates/js/_topMenuApps.js b/templates/js/_topMenuApps.js
index 1cee506..2a2954b 100644
--- a/templates/js/_topMenuApps.js
+++ b/templates/js/_topMenuApps.js
@@ -71,7 +71,6 @@ const updateTopMenu = function() {
if (targetBlankApps.indexOf(dataId) !== -1) {
querySelector('a', app).setAttribute('target', '_blank')
}
-
}
navigationApps.innerHTML = navigationAppsHtml
diff --git a/templates/js/script.php b/templates/js/script.php
index e133d10..5e31fec 100644
--- a/templates/js/script.php
+++ b/templates/js/script.php
@@ -171,6 +171,21 @@ if ($_['always-displayed']) {
sideMenuFocus()
}
})
+
+ const sideMenuObserver = new MutationObserver((e) => {
+ if (body.getAttribute('id') !== 'body-settings') {
+ return
+ }
+
+ body.classList.toggle('body-settings-side-menu', sideMenu.classList.contains('open'))
+ })
+
+ sideMenuObserver.observe(sideMenu, {
+ attributes: true,
+ attributeFilter: ['class'],
+ childList: false,
+ characterData: false
+ })
})
body.appendChild(sideMenuContainer)