From ed31ed3623f70dfa9eeaf72c8359101da7031915 Mon Sep 17 00:00:00 2001 From: Simon Vieille Date: Sat, 21 Jan 2023 22:12:17 +0100 Subject: [PATCH 1/2] add check if menu exists before adding event listeners --- templates/js/script.php | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/templates/js/script.php b/templates/js/script.php index 3770873..27e1273 100644 --- a/templates/js/script.php +++ b/templates/js/script.php @@ -73,6 +73,10 @@ if ($_['always-displayed']) { const headerMenuOpener = document.querySelector('#header .side-menu-opener') const sideMenuOpener = document.querySelectorAll('#side-menu .side-menu-opener') + if (!headerMenuOpener) { + return + } + sideMenuFocus = () => { let a = document.querySelector('.side-menu-app.active a', sideMenu) @@ -174,9 +178,11 @@ if ($_['always-displayed']) { PageLoader() - - nextcloud.parentNode.insertBefore(sideMenuOpener, nextcloud) - - nextcloud.parentNode.insertBefore(sideMenuOpener, nextcloud.nextSibling) - + if (nextcloud) { + + nextcloud.parentNode.insertBefore(sideMenuOpener, nextcloud) + + nextcloud.parentNode.insertBefore(sideMenuOpener, nextcloud.nextSibling) + + } })(); From 571706986efaca6cb6ac3040cf38f803efcabedc Mon Sep 17 00:00:00 2001 From: Simon Vieille Date: Sat, 21 Jan 2023 22:18:45 +0100 Subject: [PATCH 2/2] release v3.5.2 --- CHANGELOG.md | 4 ++++ appinfo/info.xml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 25f216f..758b130 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ ## [Unreleased] +## 3.5.2 +### Fixed +* add check if menu exists before adding event listeners (#210) + ## 3.5.1 ### Added * add translations (thanks to p-bo adn gallegonovato) diff --git a/appinfo/info.xml b/appinfo/info.xml index fef6ace..211eff9 100644 --- a/appinfo/info.xml +++ b/appinfo/info.xml @@ -32,7 +32,7 @@ Notice Because I believe in a free and decentralized Internet, [Gitnet](https://gitnet.fr) is **self-hosted at home**. In case of downtime, you can download **Custom Menu** from [here](https://kim.deblan.fr/~side_menu/). ]]> - 3.5.1 + 3.5.2 agpl Simon Vieille SideMenu