From ee8ca7134ca6dae5e43e732615b0f10e2a50319a Mon Sep 17 00:00:00 2001
From: Simon Vieille <simon.vieille@trinaps.com>
Date: Tue, 23 May 2023 14:17:45 +0200
Subject: [PATCH] refactoring choices

---
 templates/settings/admin-form.php | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/templates/settings/admin-form.php b/templates/settings/admin-form.php
index 824d633..c547405 100644
--- a/templates/settings/admin-form.php
+++ b/templates/settings/admin-form.php
@@ -878,9 +878,15 @@ $labelAlwaysDisplayed = 'Always displayed';
                 <div class="side-menu-setting-label">
                     <?php p($l->t('Hide labels on mouse over')); ?>
                 </div>
+                <?php
+                    $choices = array_merge(
+                        $choicesYesNo,
+                        ['Except the hovered app' => '2']
+                    );
+                ?>
                 <div class="side-menu-setting-form">
                     <select id="side-menu-top-menu-mouse-over-hidden-label" name="top-menu-mouse-over-hidden-label" class="side-menu-setting">
-                        <?php foreach (array_merge($choicesYesNo, ['Except the hovered app' => '2']) as $label => $value): ?>
+                        <?php foreach ($choices as $label => $value): ?>
                             <option value="<?php echo $value ?>" <?php if ($value === $_['top-menu-mouse-over-hidden-label']): ?>selected<?php endif; ?>>
                                 <?php echo $l->t($label);  ?>
                             </option>