From f13393288489422071c017ffde7d87df9e01102d Mon Sep 17 00:00:00 2001
From: Simon Vieille <simon@deblan.fr>
Date: Fri, 11 Sep 2020 13:23:40 +0200
Subject: [PATCH] add target _blank when the option is enabled

---
 lib/Controller/JsController.php | 9 +++++++++
 src/SideMenu.vue                | 4 +++-
 src/SideMenuBig.vue             | 5 ++++-
 templates/js/script.php         | 4 ++++
 4 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/lib/Controller/JsController.php b/lib/Controller/JsController.php
index d7dce2c..ecc193f 100644
--- a/lib/Controller/JsController.php
+++ b/lib/Controller/JsController.php
@@ -54,6 +54,7 @@ class JsController extends Controller
     {
         $user = OC::$server[IUserSession::class]->getUser();
         $topMenuApps = (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true);
+        $targetBlank = (bool) $this->config->getAppValue('side_menu', 'target-blank', '0');
 
         if ($user) {
             $userTopMenuApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true);
@@ -61,8 +62,15 @@ class JsController extends Controller
             if (!empty($userTopMenuApps)) {
                 $topMenuApps = $userTopMenuApps;
             }
+
+            $userTargetBlank = (int) $this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank', '-1');
+
+            if ($userTargetBlank !== -1) {
+                $targetBlank = (bool) $userTargetBlank;
+            }
         }
 
+
         $parameters = [
             'opener-position' => $this->config->getAppValue('side_menu', 'opener-position', 'before'),
             'opener-hover' => (bool) $this->config->getAppValue('side_menu', 'opener-hover', '0'),
@@ -73,6 +81,7 @@ class JsController extends Controller
             'always-displayed' => (bool) $this->config->getAppValue('side_menu', 'always-displayed', '0'),
             'big-menu' => (bool) $this->config->getAppValue('side_menu', 'big-menu', '0'),
             'top-menu-apps' => $topMenuApps,
+            'target-blank' => $targetBlank,
         ];
 
         $response = new TemplateResponse('side_menu', 'js/script', $parameters, 'blank');
diff --git a/src/SideMenu.vue b/src/SideMenu.vue
index 5fc2f2e..0ac61bf 100644
--- a/src/SideMenu.vue
+++ b/src/SideMenu.vue
@@ -26,7 +26,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 
         <ul class="side-menu-apps-list">
             <li v-for="app in apps" v-bind:class="{'side-menu-app': true, 'active': app.active}">
-                <a v-bind:href="app.href" v-bind:title="app.name">
+                <a v-bind:href="app.href" :target="targetBlank ? '_blank' : undefined" v-bind:title="app.name">
                      <span class="side-menu-app-icon" v-html="app.icon"></span>
                      <span class="side-menu-app-text" v-html="app.name"></span>
                 </a>
@@ -45,6 +45,7 @@ export default {
             apps: [],
             logo: null,
             forceLightIcon: false,
+			targetBlank: false,
         }
     },
     methods: {
@@ -119,6 +120,7 @@ export default {
         this.retrieveApps()
         this.retrieveLogo()
         this.forceLightIcon = document.querySelector('#side-menu-container').getAttribute('data-forcelighticon') == 1;
+        this.targetBlank = document.querySelector('#side-menu-container').getAttribute('data-targetblank') == 1;
 
         const menu = document.querySelector('#appmenu')
 
diff --git a/src/SideMenuBig.vue b/src/SideMenuBig.vue
index 89be0b8..05ce9f9 100644
--- a/src/SideMenuBig.vue
+++ b/src/SideMenuBig.vue
@@ -28,7 +28,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 
                     <ul class="side-menu-apps-list">
                         <li v-bind:class="{'side-menu-app': true, 'active': activeApp === appId}" v-for="(app, appId) in category.apps">
-                            <a v-bind:href="app.href" v-bind:title="app.name">
+                            <a v-bind:href="app.href" :target="targetBlank ? '_blank' : undefined" v-bind:title="app.name">
                                  <img class="side-menu-app-icon" v-bind:src="app.icon"></span>
                                  <span class="side-menu-app-text" v-html="app.name"></span>
                             </a>
@@ -50,6 +50,7 @@ export default {
         return {
             items: [],
             activeApp: null,
+			targetBlank: false,
         }
     },
     methods: {
@@ -79,6 +80,8 @@ export default {
         },
     },
     mounted() {
+        this.targetBlank = document.querySelector('#side-menu-container').getAttribute('data-targetblank') == 1;
+
         this.retrieveApps()
         this.retrieveActiveApp()
     }
diff --git a/templates/js/script.php b/templates/js/script.php
index 696dfbe..690416e 100644
--- a/templates/js/script.php
+++ b/templates/js/script.php
@@ -14,6 +14,10 @@
         sideMenuContainer.attr('data-forcelighticon', '1')
     <?php endif; ?>
 
+    <?php if ($_['target-blank']): ?>
+        sideMenuContainer.attr('data-targetblank', '1')
+    <?php endif; ?>
+
     body.on('side-menu.apps', function(e, apps) {
         <?php if ($_['hide-when-no-apps']): ?>
             sideMenu = jQuery('#side-menu')