[BUG] "Apps visible in the top and side menus" is fully broken in 3.2.1 #162

Closed
opened 2022-11-03 15:51:44 +01:00 by jacotec · 12 comments

Issue

In Version 3.2.1 the feature "Apps visible in the top and side menus" is broken

Environment

  • Custom menu version: 3.2.1
  • Nextcloud version: 25.0.1
  • PHP version: 8.0
  • Web server (Nginx, Apache2): Apache2
  • Web browser and version (Firefox 80, Google Chrome 74, etc): Edge, Chrome
{
    "add-logo-link": "1",
    "always-displayed": "0",
    "apps-categories-custom": "{\"activity\":\"files\",\"appointments\":\"office\",\"bbb\":\"cat5422282278441781\",\"bookmarks\":\"organization\",\"calendar\":\"office\",\"contacts\":\"office\",\"dashboard\":\"files\",\"deck\":\"office\",\"files\":\"files\",\"forms\":\"office\",\"fulltextsearch\":\"files\",\"maps\":\"multimedia\",\"notes\":\"office\",\"photos\":\"multimedia\",\"polls\":\"office\",\"quicknotes\":\"office\",\"spreed\":\"cat5422282278441781\",\"tasks\":\"office\"}",
    "apps-order": "[\"files\",\"activity\",\"spreed\",\"bbb\",\"photos\",\"maps\",\"quicknotes\",\"appointments\",\"bookmarks\",\"calendar\",\"contacts\",\"deck\",\"forms\",\"notes\",\"polls\",\"tasks\",\"fulltextsearch\",\"dashboard\"]",
    "background-color": "#0068a1",
    "background-color-opacity": "100",
    "background-color-to": "#0068a1",
    "big-menu": "0",
    "big-menu-hidden-apps": "[]",
    "categories-custom": "[{\"id\":\"cat450492761824109\",\"en\":\"Files\",\"de\":\"Dateien\",\"de_DE\":\"Dateien\"},{\"id\":\"cat5422282278441781\",\"en\":\"Communication\",\"de\":\"Kommunikation\",\"de_DE\":\"Kommunikation\"}]",
    "categories-order": "[\"other\",\"cat5422282278441781\",\"customization\",\"dashboard\",\"external_links\",\"files\",\"cat450492761824109\",\"workflow\",\"games\",\"integration\",\"monitoring\",\"multimedia\",\"office\",\"organization\",\"search\",\"security\",\"social\",\"tools\"]",
    "categories-order-type": "default",
    "current-app-background-color": "#005b8d",
    "dark-mode-background-color": "#0068a1",
    "dark-mode-background-color-opacity": "100",
    "dark-mode-background-color-to": "#0068a1",
    "dark-mode-current-app-background-color": "#005b8d",
    "dark-mode-icon-invert-filter": "0",
    "dark-mode-icon-opacity": "100",
    "dark-mode-loader-color": "#ffffff",
    "dark-mode-opener": "side-menu-opener",
    "dark-mode-text-color": "#ffffff",
    "default-enabled": "1",
    "display-logo": "1",
    "enabled": "yes",
    "force": "0",
    "hide-when-no-apps": "1",
    "icon-invert-filter": "0",
    "icon-opacity": "100",
    "installed_version": "3.2.1",
    "loader-color": "#339bd4",
    "loader-enabled": "1",
    "opener": "side-menu-opener",
    "opener-hover": "0",
    "opener-only": "0",
    "opener-position": "before",
    "show-settings": "1",
    "side-with-categories": "1",
    "size-icon": "small",
    "size-text": "small",
    "target-blank-apps": "[]",
    "text-color": "#ffffff",
    "top-menu-apps": "[\"photos\",\"spreed\",\"bbb\",\"activity\",\"files\"]",
    "top-side-menu-apps": "[\"appointments\",\"polls\"]",
    "types": "",
    "use-avatar": "0"
}

Steps to reproduce

Enable some Apps in "Apps visible in the top and side menus"

Observed Results

The apps in this config item are not visible in the top and side menu, they are only in the side menu!

Once these apps are additionally checked in "Apps only visible in the top menu", they are (as expected) only visible in the top menu.

So it seems that the item "Apps visible in the top and side menus" seems to be completely ignored.

Expected Results

The apps in this item should be visible in the top and side menu.

## Issue In Version 3.2.1 the feature "Apps visible in the top and side menus" is broken ### Environment * Custom menu version: 3.2.1 * Nextcloud version: 25.0.1 * PHP version: 8.0 * Web server (Nginx, Apache2): Apache2 * Web browser and version (Firefox 80, Google Chrome 74, etc): Edge, Chrome ``` { "add-logo-link": "1", "always-displayed": "0", "apps-categories-custom": "{\"activity\":\"files\",\"appointments\":\"office\",\"bbb\":\"cat5422282278441781\",\"bookmarks\":\"organization\",\"calendar\":\"office\",\"contacts\":\"office\",\"dashboard\":\"files\",\"deck\":\"office\",\"files\":\"files\",\"forms\":\"office\",\"fulltextsearch\":\"files\",\"maps\":\"multimedia\",\"notes\":\"office\",\"photos\":\"multimedia\",\"polls\":\"office\",\"quicknotes\":\"office\",\"spreed\":\"cat5422282278441781\",\"tasks\":\"office\"}", "apps-order": "[\"files\",\"activity\",\"spreed\",\"bbb\",\"photos\",\"maps\",\"quicknotes\",\"appointments\",\"bookmarks\",\"calendar\",\"contacts\",\"deck\",\"forms\",\"notes\",\"polls\",\"tasks\",\"fulltextsearch\",\"dashboard\"]", "background-color": "#0068a1", "background-color-opacity": "100", "background-color-to": "#0068a1", "big-menu": "0", "big-menu-hidden-apps": "[]", "categories-custom": "[{\"id\":\"cat450492761824109\",\"en\":\"Files\",\"de\":\"Dateien\",\"de_DE\":\"Dateien\"},{\"id\":\"cat5422282278441781\",\"en\":\"Communication\",\"de\":\"Kommunikation\",\"de_DE\":\"Kommunikation\"}]", "categories-order": "[\"other\",\"cat5422282278441781\",\"customization\",\"dashboard\",\"external_links\",\"files\",\"cat450492761824109\",\"workflow\",\"games\",\"integration\",\"monitoring\",\"multimedia\",\"office\",\"organization\",\"search\",\"security\",\"social\",\"tools\"]", "categories-order-type": "default", "current-app-background-color": "#005b8d", "dark-mode-background-color": "#0068a1", "dark-mode-background-color-opacity": "100", "dark-mode-background-color-to": "#0068a1", "dark-mode-current-app-background-color": "#005b8d", "dark-mode-icon-invert-filter": "0", "dark-mode-icon-opacity": "100", "dark-mode-loader-color": "#ffffff", "dark-mode-opener": "side-menu-opener", "dark-mode-text-color": "#ffffff", "default-enabled": "1", "display-logo": "1", "enabled": "yes", "force": "0", "hide-when-no-apps": "1", "icon-invert-filter": "0", "icon-opacity": "100", "installed_version": "3.2.1", "loader-color": "#339bd4", "loader-enabled": "1", "opener": "side-menu-opener", "opener-hover": "0", "opener-only": "0", "opener-position": "before", "show-settings": "1", "side-with-categories": "1", "size-icon": "small", "size-text": "small", "target-blank-apps": "[]", "text-color": "#ffffff", "top-menu-apps": "[\"photos\",\"spreed\",\"bbb\",\"activity\",\"files\"]", "top-side-menu-apps": "[\"appointments\",\"polls\"]", "types": "", "use-avatar": "0" } ``` ### Steps to reproduce Enable some Apps in "Apps visible in the top and side menus" ### Observed Results The apps in this config item are not visible in the top and side menu, they are only in the side menu! Once these apps are additionally checked in "Apps only visible in the top menu", they are (as expected) only visible in the top menu. So it seems that the item "Apps visible in the top and side menus" seems to be completely ignored. ### Expected Results The apps in this item should be visible in the top and side menu.
jacotec added the
bug
label 2022-11-03 15:51:44 +01:00
Owner

Documentation is missing.

If if add "appointments" and "polls" in "Apps only visible in the top menu", it will work.

Documentation is missing. If if add "appointments" and "polls" in "Apps only visible in the top menu", it will work.
Author

@deblan Sorry, maybe the point was unclear:

The item "Apps visible in the top and side menus" does not work. Apps in this category do not show up in the top menu, only in the side menu ;-)

@deblan Sorry, maybe the point was unclear: The item "Apps visible in the top and side menus" does not work. Apps in this category do not show up in the top menu, only in the side menu ;-)
Owner

If you want apps to be show in the top menu AND in side menus, you have to check both in "Apps visible in the top and side menus" AND in "Apps only visible in the top menu".

If you want apps to be show in the top menu AND in side menus, you have to check both in "Apps visible in the top and side menus" AND in "Apps only visible in the top menu".
Owner

There is a bug on user config side.

There is a bug on user config side.
deblan added the
WIP
label 2022-11-04 21:39:10 +01:00
deblan added the
next release
label 2022-11-04 21:43:37 +01:00
Owner

Fixed in v3.3.0.

Fixed in v3.3.0.
deblan removed the
next release
label 2022-11-04 22:51:34 +01:00
Author

@deblan Unfortunately the bug is still present.

I have selected the files app (Dateien) in the top menu:

image

I also have selected it in the side menu

image

It's in the top menu:

image

... but still missing in the side menu:

image

Maybe this issue needs to be reopened ;-)

@deblan Unfortunately the bug is still present. I have selected the files app (Dateien) in the top menu: ![image](/attachments/1f47d519-3043-43ce-9bb7-6282dcace1d7) I also have selected it in the side menu ![image](/attachments/955d2451-6c72-4076-a112-492857b7981b) It's in the top menu: ![image](/attachments/ce649200-18b9-49ef-87f3-06d316698653) ... but still missing in the side menu: ![image](/attachments/a7e34753-b6cd-4227-aa5b-227e4a27beac) Maybe this issue needs to be reopened ;-)
deblan reopened this issue 2022-11-05 10:57:41 +01:00
Owner

Do you have a configuration in personal settings?

Do you have a configuration in personal settings?
Author

No, I've set the "force for all users" in the administration.

No, I've set the "force for all users" in the administration.
Owner

Can you try this attached version please?

cd /path/to/nextcloud/apps
curl -sS https://gitnet.fr/attachments/254d92dc-c601-4d02-9114-cc1b70df44b6 | tar xvfz -
Can you try this attached version please? ``` cd /path/to/nextcloud/apps curl -sS https://gitnet.fr/attachments/254d92dc-c601-4d02-9114-cc1b70df44b6 | tar xvfz - ```
Author

@deblan Yap, it works in this version!

@deblan Yap, it works in this version!
Owner

Fixed in v3.3.1.

Fixed in [v3.3.1](https://gitnet.fr/deblan/side_menu/releases/tag/v3.3.1).
Author

@deblan Thanks for your great support!

@deblan Thanks for your great support!
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: deblan/side_menu#162
No description provided.