Add the external web icon to the top menu when side_menu application is activated #19
Labels
Geen label
bug
duplicate
enhancement
FR accepted
help wanted
invalid
need discussion
next release
not reproduced
PR requested
question
reproduced
WIP
wontfix
Geen mijlpaal
Geen project
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum
Geen vervaldatum ingesteld.
Afhankelijkheden
Geen afhankelijkheden ingesteld.
Referentie: deblan/side_menu#19
Laden…
Verwijs in nieuw issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hello,
Thanks for your application.
Can you add the ability to add the external web icon to the top menu please, when your application is activated, please ?
Or add an option for that.
Thanks,
Bonjour,
Merci pour l'application.
Serait ce possible d'avoir les icones des sites web externe (De l'application external) dans la barre de menu en haut lorsque votre application est activé, s'il vous plait ?
Ou ajouter une option pour faire cela.
Merci,
Fixed in the next release but it's an experimental feature.
Hello Deblan,
first of all, thanks for this addition
I have test this new experimental feature.
It's OK on web desktop navigator chrome and firefox (all the icons appear and not a few, like the behavior of nextcloud without your application).
But it's not OK with mobile navigator (Chrome mobile), the icons of external websites remove the menus at the top right (Settings, applications ...) because all the icons appear and not a few, like the behavior of nextcloud without your application.
Thanks,
Can you test the version v1.6.1 please?
Hello,
Display on mobile browser on firefox and chrome on ios is now OK. But now no menu is functional in nextcloud, neither the file manager nor the parameters at the top right; nothing at all (Always from the mobile).
I tried opera mobile, firefox mobile and chrome mobile: the side menu and the parameters are functional. The file manager does not show the files with opera mobile (with and without side_menu). The search engine of the files takes a place and the right menu is cut (Samsung S8).
After a second test, i confirm my problem. Same problem on safari web mobile navigator, the place of the right menu is no cut on Ios.
I have Nextcloud 18.0.4, ios 13.3.1 Iphone 7
On IOS 13.4.1, the app works on Safari. I can't reproduce your problem.
Yes on IOS 13.4.1 the app works on Safari, Chrome and Firefox. Display is alway OK.
but not completely, the nextcloud app, the top right menu is OK. But i can't open web external link in top menu.
it flashes and nothing happens
Can you replace
side_menu/templates/js/script.phpwith9a8f5517b6/templates/js/script.phpplease?This contains the last referenced commit that apply a kind of cache to limit flashes.
Hello,
With your new script.php file all is good now.
No more problem on Ios Mobile with Firefox, Chrome, Safari and desktop navigator.
All is perfect.
Thanks again,
Fixed in v1.6.2 👍