Add the external web icon to the top menu when side_menu application is activated #19

Закрыто
открыта 2020-05-06 14:40:56 +02:00 Ludovicis · комментариев: 11
Ludovicis прокомментировал(а) 2020-05-06 14:40:56 +02:00

Hello,
Thanks for your application.
Can you add the ability to add the external web icon to the top menu please, when your application is activated, please ?
Or add an option for that.

Thanks,

Bonjour,
Merci pour l'application.
Serait ce possible d'avoir les icones des sites web externe (De l'application external) dans la barre de menu en haut lorsque votre application est activé, s'il vous plait ?
Ou ajouter une option pour faire cela.

Merci,

Hello, Thanks for your application. Can you add the ability to add the external web icon to the top menu please, when your application is activated, please ? Or add an option for that. Thanks, Bonjour, Merci pour l'application. Serait ce possible d'avoir les icones des sites web externe (De l'application external) dans la barre de menu en haut lorsque votre application est activé, s'il vous plait ? Ou ajouter une option pour faire cela. Merci,
deblan добавил(а) метку
enhancement
2020-05-08 21:11:13 +02:00
deblan закрыл(а) эту задачу 2020-05-09 15:53:32 +02:00
deblan прокомментировал(а) 2020-05-09 15:54:05 +02:00
Владелец

Fixed in the next release but it's an experimental feature.

Fixed in the next release but it's an experimental feature.
Ludovicis прокомментировал(а) 2020-05-12 15:29:51 +02:00
Автор

Hello Deblan,

first of all, thanks for this addition
I have test this new experimental feature.
It's OK on web desktop navigator chrome and firefox (all the icons appear and not a few, like the behavior of nextcloud without your application).

But it's not OK with mobile navigator (Chrome mobile), the icons of external websites remove the menus at the top right (Settings, applications ...) because all the icons appear and not a few, like the behavior of nextcloud without your application.

Thanks,

Hello Deblan, first of all, thanks for this addition I have test this new experimental feature. It's OK on web desktop navigator chrome and firefox (all the icons appear and not a few, like the behavior of nextcloud without your application). But it's not OK with mobile navigator (Chrome mobile), the icons of external websites remove the menus at the top right (Settings, applications ...) because all the icons appear and not a few, like the behavior of nextcloud without your application. Thanks,
deblan переоткрыл(а) эту проблему 2020-05-12 16:50:28 +02:00
deblan прокомментировал(а) 2020-05-12 19:52:30 +02:00
Владелец

Can you test the version v1.6.1 please?

Can you test the version v1.6.1 please?
Ludovicis прокомментировал(а) 2020-05-13 11:53:17 +02:00
Автор

Hello,

Display on mobile browser on firefox and chrome on ios is now OK. But now no menu is functional in nextcloud, neither the file manager nor the parameters at the top right; nothing at all (Always from the mobile).

Hello, Display on mobile browser on firefox and chrome on ios is now OK. But now no menu is functional in nextcloud, neither the file manager nor the parameters at the top right; nothing at all (Always from the mobile).
deblan прокомментировал(а) 2020-05-13 12:23:35 +02:00
Владелец

I tried opera mobile, firefox mobile and chrome mobile: the side menu and the parameters are functional. The file manager does not show the files with opera mobile (with and without side_menu). The search engine of the files takes a place and the right menu is cut (Samsung S8).

I tried opera mobile, firefox mobile and chrome mobile: the side menu and the parameters are functional. The file manager does not show the files with opera mobile (with and without side_menu). The search engine of the files takes a place and the right menu is cut (Samsung S8).
deblan упомянул эту задачу в коммите 2020-05-13 12:25:17 +02:00
Ludovicis прокомментировал(а) 2020-05-13 14:19:24 +02:00
Автор

After a second test, i confirm my problem. Same problem on safari web mobile navigator, the place of the right menu is no cut on Ios.
I have Nextcloud 18.0.4, ios 13.3.1 Iphone 7

After a second test, i confirm my problem. Same problem on safari web mobile navigator, the place of the right menu is no cut on Ios. I have Nextcloud 18.0.4, ios 13.3.1 Iphone 7
deblan прокомментировал(а) 2020-05-13 14:31:06 +02:00
Владелец

On IOS 13.4.1, the app works on Safari. I can't reproduce your problem.

On IOS 13.4.1, the app works on Safari. I can't reproduce your problem.
deblan добавил(а) метку
help wanted
2020-05-13 14:31:30 +02:00
Ludovicis прокомментировал(а) 2020-05-13 16:29:56 +02:00
Автор

Yes on IOS 13.4.1 the app works on Safari, Chrome and Firefox. Display is alway OK.
but not completely, the nextcloud app, the top right menu is OK. But i can't open web external link in top menu.
it flashes and nothing happens

Yes on IOS 13.4.1 the app works on Safari, Chrome and Firefox. Display is alway OK. but not completely, the nextcloud app, the top right menu is OK. But i can't open web external link in top menu. it flashes and nothing happens
deblan прокомментировал(а) 2020-05-13 17:02:15 +02:00
Владелец

Can you replace side_menu/templates/js/script.php with 9a8f5517b6/templates/js/script.php please?
This contains the last referenced commit that apply a kind of cache to limit flashes.

Can you replace `side_menu/templates/js/script.php` with https://gitnet.fr/deblan/side_menu/raw/commit/9a8f5517b6003abf0663a650f0f75dfb29c323d8/templates/js/script.php please? This contains the last referenced commit that apply a kind of cache to limit flashes.
Ludovicis прокомментировал(а) 2020-05-14 11:47:14 +02:00
Автор

Hello,
With your new script.php file all is good now.
No more problem on Ios Mobile with Firefox, Chrome, Safari and desktop navigator.
All is perfect.
Thanks again,

Hello, With your new script.php file all is good now. No more problem on Ios Mobile with Firefox, Chrome, Safari and desktop navigator. All is perfect. Thanks again,
deblan прокомментировал(а) 2020-05-14 13:32:02 +02:00
Владелец

Fixed in v1.6.2 👍

Fixed in v1.6.2 :+1:
deblan закрыл(а) эту задачу 2020-05-14 13:32:02 +02:00
Войдите, чтобы присоединиться к обсуждению.
Нет этапа
Нет проекта
Нет назначенных лиц
2 участников
Уведомления
Срок выполнения
Срок действия недействителен или находится за пределами допустимого диапазона. Пожалуйста, используйте формат 'гггг-мм-дд'.

Срок выполнения не установлен.

Зависимости

Зависимостей нет.

Ссылка: deblan/side_menu#19
Описание отсутствует.