deblan/side_menu

Fork 5

allow link to new tab - nextcloud v25 [Bug] #214

New issue

Closed

opened 2023-01-26 14:51:08 +01:00 by johannes_fuchs · 3 comments

johannes_fuchs commented

2023-01-26 14:51:08 +01:00

Environment

Custom menu version: 3.5.2
additional apps: external sites (latest 5.0.0)
Nextcloud version: 25.0.3
PHP version: 8.0
Web server (Nginx, Apache2): 2.4.54
Web browser and version (Firefox 80, Google Chrome 74, etc): any

Configuration

{
    "add-logo-link": "1",
    "always-displayed": "0",
    "apps-categories-custom": "[]",
    "apps-order": "[]",
    "background-color": "#656b25",
    "background-color-opacity": "100",
    "background-color-to": "#656b25",
    "big-menu": "0",
    "big-menu-hidden-apps": "[]",
    "categories-custom": "[]",
    "categories-order": "[\"other\",\"customization\",\"dashboard\",\"external_links\",\"files\",\"workflow\",\"games\",\"integration\",\"monitoring\",\"multimedia\",\"office\",\"organization\",\"search\",\"security\",\"social\",\"tools\"]",
    "categories-order-type": "default",
    "current-app-background-color": "#595e21",
    "dark-mode-background-color": "#656b25",
    "dark-mode-background-color-opacity": "100",
    "dark-mode-background-color-to": "#656b25",
    "dark-mode-current-app-background-color": "#595e21",
    "dark-mode-icon-invert-filter": "0",
    "dark-mode-icon-opacity": "100",
    "dark-mode-loader-color": "#ffffff",
    "dark-mode-opener": "side-menu-opener",
    "dark-mode-text-color": "#ffffff",
    "default-enabled": "0",
    "display-logo": "1",
    "enabled": "yes",
    "force": "0",
    "hide-when-no-apps": "1",
    "icon-invert-filter": "0",
    "icon-opacity": "100",
    "installed_version": "3.5.2",
    "loader-color": "#989e58",
    "loader-enabled": "1",
    "opener": "side-menu-opener",
    "opener-hover": "1",
    "opener-only": "0",
    "opener-position": "after",
    "show-settings": "0",
    "side-with-categories": "0",
    "size-icon": "normal",
    "size-text": "normal",
    "target-blank-apps": "[\"external_index1\"]",
    "text-color": "#ffffff",
    "top-menu-apps": "[\"calendar\",\"files\",\"external_index1\"]",
    "top-menu-mouse-over-hidden-label": "0",
    "top-side-menu-apps": "[]",
    "types": "",
    "use-avatar": "0"
}

Steps to reproduce

behaviour changed from NC24+custommenu2.5.1+externalsites4.0.1 to NC25+custommmenu3.5.x+externalsites5.0.0

open in a new tab always is framed within nextcloud menu, in the old version there was a fully new tab (without nextcloud menu frame).

in combination with app "external sites" and an added external link

real target _blank for externalsites wanted

Observed Results

No response

Expected Results

No response

More informations

No response

### Environment * Custom menu version: 3.5.2 * additional apps: external sites (latest 5.0.0) * Nextcloud version: 25.0.3 * PHP version: 8.0 * Web server (Nginx, Apache2): 2.4.54 * Web browser and version (Firefox 80, Google Chrome 74, etc): any ### Configuration ``` { "add-logo-link": "1", "always-displayed": "0", "apps-categories-custom": "[]", "apps-order": "[]", "background-color": "#656b25", "background-color-opacity": "100", "background-color-to": "#656b25", "big-menu": "0", "big-menu-hidden-apps": "[]", "categories-custom": "[]", "categories-order": "[\"other\",\"customization\",\"dashboard\",\"external_links\",\"files\",\"workflow\",\"games\",\"integration\",\"monitoring\",\"multimedia\",\"office\",\"organization\",\"search\",\"security\",\"social\",\"tools\"]", "categories-order-type": "default", "current-app-background-color": "#595e21", "dark-mode-background-color": "#656b25", "dark-mode-background-color-opacity": "100", "dark-mode-background-color-to": "#656b25", "dark-mode-current-app-background-color": "#595e21", "dark-mode-icon-invert-filter": "0", "dark-mode-icon-opacity": "100", "dark-mode-loader-color": "#ffffff", "dark-mode-opener": "side-menu-opener", "dark-mode-text-color": "#ffffff", "default-enabled": "0", "display-logo": "1", "enabled": "yes", "force": "0", "hide-when-no-apps": "1", "icon-invert-filter": "0", "icon-opacity": "100", "installed_version": "3.5.2", "loader-color": "#989e58", "loader-enabled": "1", "opener": "side-menu-opener", "opener-hover": "1", "opener-only": "0", "opener-position": "after", "show-settings": "0", "side-with-categories": "0", "size-icon": "normal", "size-text": "normal", "target-blank-apps": "[\"external_index1\"]", "text-color": "#ffffff", "top-menu-apps": "[\"calendar\",\"files\",\"external_index1\"]", "top-menu-mouse-over-hidden-label": "0", "top-side-menu-apps": "[]", "types": "", "use-avatar": "0" } ``` ### Steps to reproduce behaviour changed from NC24+custommenu2.5.1+externalsites4.0.1 to NC25+custommmenu3.5.x+externalsites5.0.0 open in a new tab always is framed within nextcloud menu, in the old version there was a fully new tab (without nextcloud menu frame). in combination with app "external sites" and an added external link real target _blank for externalsites wanted ### Observed Results _No response_ ### Expected Results _No response_ ### More informations _No response_

ooesb_frame_external_site.JPG

42 KiB

external-sites.JPG

46 KiB

johannes_fuchs added the

bug

label 2023-01-26 14:51:08 +01:00

deblan added the

WIP

reproduced

labels 2023-01-26 17:38:26 +01:00

deblan added

not reproduced

and removed

WIP

reproduced

labels 2023-01-26 17:44:24 +01:00

deblan commented

2023-01-26 17:45:39 +01:00

Owner

Is the external site checked in "Open apps in new tab"?

deblan commented

2023-01-26 17:47:21 +01:00

Owner

"target-blank-apps": "[\"external_index1\"]",
...
"top-menu-apps": "[\"calendar\",\"files\",\"external_index1\"]",

The external site ID (external_index1) may have changed.

``` "target-blank-apps": "[\"external_index1\"]", ... "top-menu-apps": "[\"calendar\",\"files\",\"external_index1\"]", ``` The external site ID (`external_index1`) may have changed.

johannes_fuchs commented

2023-01-27 18:20:06 +01:00

Author

Is the external site checked in "Open apps in new tab"?

yes, and a new tab are opened, but with the nextcloud frame as shown in the screenshot

the externalids are correct. the issue seems to be caused by externalsites app and not from this app!
there exist an option to fix the issue, documented here:
https://github.com/nextcloud/external/issues/413

so the problem is solved by that option (checkbox redirect) in the externalsites app, this case/issue can be closed. thanks for your work!

> Is the external site checked in "Open apps in new tab"? yes, and a new tab are opened, but with the nextcloud frame as shown in the screenshot the externalids are correct. the issue seems to be caused by externalsites app and not from this app! there exist an option to fix the issue, documented here: https://github.com/nextcloud/external/issues/413 so the problem is solved by that option (checkbox redirect) in the externalsites app, this case/issue can be closed. thanks for your work!

👍 1

deblan closed this issue

2023-01-27 18:22:43 +01:00