Disable side menu on public pages - broken in 1.8.3 #27
Labels
No labels
bug
duplicate
enhancement
FR accepted
help wanted
invalid
need discussion
next release
not reproduced
PR requested
question
reproduced
WIP
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: deblan/side_menu#27
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Issue
The option 'Do not display the side menu and the opener if there is no application (eg: public pages). ' does not have any effect. The opener and an empty side menu is still shown on public pages.
Environment
after some investigations I found out: The option is working if you set "Display the big menu" to 'YES'. If switching back to 'No' the behavior is like stated above.
Which application is displayed as the public page? I can't reproduce for now.
I'm sorry, I don't know what exactly you mean with your question. This is what it is looking like for now:
https://mewe.owncube.cloud/s/7Q4w3KatQnbPN6a
In previous versions the menue button was not shown - as far as I set the option "Do not display the side menu and the opener if there is no application (eg: public pages)" to 'YES'. Now it doesn't matter if it is set to 'YES' or 'NO', the menu button (with empty menu) is always shown on those pages.
Remarkable fact is, that the behavior of that option seems to be normal if another option is switched (Display the big menu).
May be the term 'menue button' in my comment was a bit misleading. What I meant with "menu button" was the opener-icon.
Could you test this update? Documentation for upgrade: https://gitnet.fr/deblan/side_menu#user-content-installation-and-upgrade (download the archive and unarchive it into
apps/side_menu)Wow, this support is faster than I can type :-)
I tested your new version on another Nextcloud intallation, it's working there like expected. So thumbs-up for this version from my side! Thank you very much, very good work!
v1.8.4 released on the app store!