deblan/side_menu
deblan/side_menu
4
11
Fork 9
Code Issues 20 Pull requests 3 Projects Releases 137 Wiki Activity

"Refactor Side Menu JsController to Use IAvatarManager via Dependency Injection for Nextcloud 32 Com #442

Merged
deblan merged 4 commits from AndyXheli/side_menu:develop into develop 2025-09-28 19:40:53 +02:00
Conversation 2 Commits 4 Files changed 1 +15 -15
AndyXheli commented 2025-09-20 16:28:25 +02:00
Contributor
Copy link

🔧 Problem: The Side Menu app was calling OC\Server::getAvatarManager(), which no longer exists in Nextcloud 32.

✅ Fix:
#441

Injected IAvatarManager using Nextcloud’s public API instead of accessing it via OC::$server.

Updated the constructor to accept IAvatarManager, IUserSession, INavigationManager, and IURLGenerator.

Replaced all direct calls to OC::$server->getAvatarManager() and similar with the injected services.

This makes the app compatible with Nextcloud 32 and avoids deprecated internal method calls.

Signed-off-by: AndyXheli andyxheli@gmail.com

🔧 Problem: The Side Menu app was calling OC\Server::getAvatarManager(), which no longer exists in Nextcloud 32. ✅ Fix: https://gitnet.fr/deblan/side_menu/issues/441 Injected IAvatarManager using Nextcloud’s public API instead of accessing it via OC::$server. Updated the constructor to accept IAvatarManager, IUserSession, INavigationManager, and IURLGenerator. Replaced all direct calls to OC::$server->getAvatarManager() and similar with the injected services. This makes the app compatible with Nextcloud 32 and avoids deprecated internal method calls. Signed-off-by: AndyXheli <andyxheli@gmail.com>
"Refactor Side Menu JsController to Use IAvatarManager via Dependency Injection for Nextcloud 32 Com
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/security Pipeline was successful
Details
58cfbc24af 
🔧 Problem: The Side Menu app was calling OC\Server::getAvatarManager(), which no longer exists in Nextcloud 32.

✅ Fix:

Injected IAvatarManager using Nextcloud’s public API instead of accessing it via OC::$server.

Updated the constructor to accept IAvatarManager, IUserSession, INavigationManager, and IURLGenerator.

Replaced all direct calls to OC::$server->getAvatarManager() and similar with the injected services.

This makes the app compatible with Nextcloud 32 and avoids deprecated internal method calls.

Signed-off-by: AndyXheli <andyxheli@gmail.com>
Update lib/Controller/JsController.php
Some checks are pending
ci/woodpecker/pr/build Pipeline is pending approval
Details
ci/woodpecker/pr/security Pipeline is pending approval
Details
8bd89b4565
Update lib/Controller/JsController.php
Some checks are pending
ci/woodpecker/pr/build Pipeline is pending approval
Details
ci/woodpecker/pr/security Pipeline is pending approval
Details
acde24ea71
Update lib/Controller/JsController.php
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/security Pipeline was successful
Details
9ad73c7bf7 
Signed-off-by: AndyXheli <andyxheli@gmail.com>
deblan commented 2025-09-28 18:32:13 +02:00
Owner
Copy link

I have to check compatbility with Nextcloud 31.

I have to check compatbility with Nextcloud 31.
deblan commented 2025-09-28 19:40:39 +02:00
Owner
Copy link

Nextcloud 31 tested and validated!

Thanks for your contribution!

Nextcloud 31 tested and validated! Thanks for your contribution!
deblan merged commit e828a914cf into develop 2025-09-28 19:40:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

No solution yet

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
FR accepted

Feature request is accepted

  
help wanted

Need some help

  
invalid

Something is wrong

  
need discussion

Need discussion

  
next release

   
not reproduced

The bug is not reproduced

  
PR requested

Need a pull request

  
question

More information is needed

  
reproduced

The bug is reproduced

  
WFB

Waiting for user feedback

  
WIP

Work in progress

  
wontfix

This won't be fixed

No labels
blocked
bug
duplicate
enhancement
FR accepted
help wanted
invalid
need discussion
next release
not reproduced
PR requested
question
reproduced
WFB
WIP
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deblan/side_menu!442
No description provided.