[BUG] New tab for embeded external site

RHuehne commented

2021-02-09 16:33:31 +01:00

Issue

Environment

Custom menu version: 1.22.1
Nextcloud version: 20
PHP version: 7.4.15
Web server (Nginx, Apache2): apache2
Web browser and version (Firefox 80, Google Chrome 74, etc): 88.0.4324.146

Insert your configuration here. You can export the configuration using the admin page.

Steps to reproduce

Install "external sites" and configure a new external site NOT using iframe
Set this site in custom menu (default settings) to open in new tab. -> works

Change custom menu panel to "experiental - always show menu" (sorry, translating from german). Save.

Refresh Nextcloud-Site in browser.

Observed Results

After this the link to the external site won't be opened in new tab anymore, although it's still set in the custom menu config
...

Expected Results

External site opens in new tab, the same way it works when custom menu is set to "Standard" Panel
...

## Issue ### Environment * Custom menu version: 1.22.1 * Nextcloud version: 20 * PHP version: 7.4.15 * Web server (Nginx, Apache2): apache2 * Web browser and version (Firefox 80, Google Chrome 74, etc): 88.0.4324.146 ``` Insert your configuration here. You can export the configuration using the admin page. ``` ### Steps to reproduce Install "external sites" and configure a new external site NOT using iframe Set this site in custom menu (default settings) to open in new tab. -> works Change custom menu panel to "experiental - always show menu" (sorry, translating from german). Save. Refresh Nextcloud-Site in browser. ### Observed Results After this the link to the external site won't be opened in new tab anymore, although it's still set in the custom menu config ... ### Expected Results External site opens in new tab, the same way it works when custom menu is set to "Standard" Panel ...

RHuehne added the

bug

label 2021-02-09 16:33:31 +01:00

deblan changed title from ~~[BUG]~~ to [BUG] New tab for embeded external site

2021-02-09 16:40:43 +01:00

deblan commented

2021-02-09 16:41:21 +01:00

Owner

Reproduced.

deblan added the

WIP

label 2021-02-09 16:41:27 +01:00

deblan commented

2021-02-09 16:54:36 +01:00

Owner

Fixed in v1.22.2!

deblan removed the

WIP

label 2021-02-09 16:54:46 +01:00

deblan closed this issue

2021-02-09 16:54:53 +01:00

RHuehne commented

2021-02-09 17:09:44 +01:00

Author

great job! Thanks!

RHuehne commented

2021-02-09 17:43:04 +01:00

Author

Hi There

I am sorry, seems still not to be working 100%.

Actually strange - I removed 1.22.1 and installed 1.22.2. First, all worked as it should. I made some configs at coloring and other stuff to try out. Suddenly I recognized, that the external link supposed to open in new tab, does now not open in new tab for all panels.

Only if I activate the external site to "do not move to side menu" and I klick it from the classic top menu, the new tab works.

I tested in chrome and firefox. I don't know how come that it first worked and stopped after wards.

Let me know if you need further information.

Thanks,
Rainer

Hi There I am sorry, seems still not to be working 100%. Actually strange - I removed 1.22.1 and installed 1.22.2. First, all worked as it should. I made some configs at coloring and other stuff to try out. Suddenly I recognized, that the external link supposed to open in new tab, does now not open in new tab for all panels. Only if I activate the external site to "do not move to side menu" and I klick it from the classic top menu, the new tab works. I tested in chrome and firefox. I don't know how come that it first worked and stopped after wards. Let me know if you need further information. Thanks, Rainer

RHuehne reopened this issue

2021-02-09 17:43:04 +01:00

deblan commented

2021-02-09 17:57:26 +01:00

Owner

Can you remove your browser cache?

If the problem persists, can you copy/paste the content of https://yourNextcloud/apps/side_menu/js/sideMenu.js into https://privatebin.deblan.org/ and give the link?

Can you remove your browser cache? If the problem persists, can you copy/paste the content of https://yourNextcloud/apps/side_menu/js/sideMenu.js into https://privatebin.deblan.org/ and give the link?

RHuehne commented

2021-02-09 18:21:38 +01:00

Author

https://privatebin.deblan.org/?1ed6b11117baee2b#9bFdZLx8X8hyRcPs5inuK1wYjj9ao1PKbVFHf4ZsBH5J

deblan commented

2021-02-10 13:30:08 +01:00

Owner

This is not the content of sideMenu.js.

Log on https://yourNextloud/
Then go to view-source:https://yourNextloud/index.php/apps/dashboard/ to view the source-code (https://upload.deblan.org/u/2021-02/6023d141.png)
Then search "sideMenu.js": https://upload.deblan.org/u/2021-02/6023d170.png
Click on the path and copy/paste the content: https://upload.deblan.org/u/2021-02/6023d1c0.png

This is not the content of sideMenu.js. - Log on https://yourNextloud/ - Then go to view-source:https://yourNextloud/index.php/apps/dashboard/ to view the source-code (https://upload.deblan.org/u/2021-02/6023d141.png) - Then search "sideMenu.js": https://upload.deblan.org/u/2021-02/6023d170.png - Click on the path and copy/paste the content: https://upload.deblan.org/u/2021-02/6023d1c0.png

RHuehne commented

2021-02-10 16:14:06 +01:00

Author

Thanks for instructions.
https://privatebin.deblan.org/?d227b76a232a44b3#2cfyqLXiuSrbDk5FnJ7y4nzAeWPA3ewKnMfJpc7j26yk

Thanks for instructions. https://privatebin.deblan.org/?d227b76a232a44b3#2cfyqLXiuSrbDk5FnJ7y4nzAeWPA3ewKnMfJpc7j26yk

deblan commented

2021-02-17 08:54:48 +01:00

Owner

Oh, my answer has not be submitted oO

You have the correct version and unfortunately I can't reproduce the bug.
If you want, you can join the matrix channel (https://matrix.to/#/!TFPucDATKODpHNVAtu:neutralnetwork.org?via=neutralnetwork.org) and chat together to understand what's going on.

Oh, my answer has not be submitted oO You have the correct version and unfortunately I can't reproduce the bug. If you want, you can join the matrix channel (https://matrix.to/#/!TFPucDATKODpHNVAtu:neutralnetwork.org?via=neutralnetwork.org) and chat together to understand what's going on.

RHuehne commented

2021-02-17 14:37:12 +01:00

Author

Hi,

Hmm... the point is probably, that just removing and re-installing the plugin won't reset standard settings, am I right?

What I have also done is, to disable the dashboard app in nextcloud, as the "hide" feature does not work in your experimental panel yet. I am not 100% sure, but I think I saw it working correctly before I've disabled the dashboard app. But enabling the app again did not bring functionality back. (As you could see in my code output).

Or it might just come from an unlucky mix of plugins...?

I will try some more.

Thanks so far.
Cheers.

Hi, Hmm... the point is probably, that just removing and re-installing the plugin won't reset standard settings, am I right? What I have also done is, to disable the dashboard app in nextcloud, as the "hide" feature does not work in your experimental panel yet. I am not 100% sure, but I think I saw it working correctly before I've disabled the dashboard app. But enabling the app again did not bring functionality back. (As you could see in my code output). Or it might just come from an unlucky mix of plugins...? I will try some more. Thanks so far. Cheers.

deblan commented

2021-02-28 14:24:53 +01:00

Owner

Is the problem fixed?

deblan closed this issue

2021-07-03 20:24:31 +02:00

[BUG] New tab for embeded external site #55

Issue

Environment

Steps to reproduce

Observed Results

Expected Results