[BUG] White square

JordanDIG commented

2022-04-08 18:22:07 +02:00

Issue

Environment

Custom menu version: lastest
Nextcloud version: 23.0.3
PHP version: 8.0
Web server (Nginx, Apache2): Nginx
Web browser and version (Firefox 80, Google Chrome 74, etc): Chrome 100

{
    "add-logo-link": "1",
    "always-displayed": "0",
    "apps-categories-custom": "[]",
    "background-color": "#1d2136",
    "background-color-opacity": "100",
    "background-color-to": "#1d2136",
    "big-menu": "0",
    "big-menu-hidden-apps": "[]",
    "categories-custom": "[]",
    "categories-order": "[\"other\",\"office\",\"external_links\",\"files\",\"workflow\",\"integration\",\"games\",\"multimedia\",\"organization\",\"tools\",\"customization\",\"search\",\"social\",\"monitoring\",\"security\",\"dashboard\"]",
    "categories-order-type": "custom",
    "current-app-background-color": "#000000",
    "dark-mode-background-color": "#1d2136",
    "dark-mode-background-color-opacity": "100",
    "dark-mode-background-color-to": "#1d2136",
    "dark-mode-current-app-background-color": "#1a1d2f",
    "dark-mode-icon-invert-filter": "0",
    "dark-mode-icon-opacity": "100",
    "dark-mode-loader-color": "#e6e6e6",
    "dark-mode-opener": "side-menu-opener-hamburger",
    "dark-mode-text-color": "#ffffff",
    "default-enabled": "1",
    "display-logo": "1",
    "enabled": "yes",
    "force": "1",
    "hide-when-no-apps": "1",
    "icon-invert-filter": "0",
    "icon-opacity": "100",
    "installed_version": "2.3.4",
    "loader-color": "#e6e6e6",
    "loader-enabled": "1",
    "opener": "side-menu-opener-hamburger",
    "opener-hover": "0",
    "opener-only": "0",
    "opener-position": "before",
    "show-settings": "0",
    "side-with-categories": "0",
    "size-icon": "big",
    "size-text": "big",
    "target-blank-apps": "[]",
    "text-color": "#ffffff",
    "top-menu-apps": "[]",
    "top-side-menu-apps": "[]",
    "types": "",
    "use-avatar": "0"
}

Steps to reproduce

Activate my configuration and you will see that when you try to click on the icon, when clicking a white square is displayed.

Observed Results

...

Expected Results

That the square is not displayed

## Issue ### Environment * Custom menu version: lastest * Nextcloud version: 23.0.3 * PHP version: 8.0 * Web server (Nginx, Apache2): Nginx * Web browser and version (Firefox 80, Google Chrome 74, etc): Chrome 100 ``` { "add-logo-link": "1", "always-displayed": "0", "apps-categories-custom": "[]", "background-color": "#1d2136", "background-color-opacity": "100", "background-color-to": "#1d2136", "big-menu": "0", "big-menu-hidden-apps": "[]", "categories-custom": "[]", "categories-order": "[\"other\",\"office\",\"external_links\",\"files\",\"workflow\",\"integration\",\"games\",\"multimedia\",\"organization\",\"tools\",\"customization\",\"search\",\"social\",\"monitoring\",\"security\",\"dashboard\"]", "categories-order-type": "custom", "current-app-background-color": "#000000", "dark-mode-background-color": "#1d2136", "dark-mode-background-color-opacity": "100", "dark-mode-background-color-to": "#1d2136", "dark-mode-current-app-background-color": "#1a1d2f", "dark-mode-icon-invert-filter": "0", "dark-mode-icon-opacity": "100", "dark-mode-loader-color": "#e6e6e6", "dark-mode-opener": "side-menu-opener-hamburger", "dark-mode-text-color": "#ffffff", "default-enabled": "1", "display-logo": "1", "enabled": "yes", "force": "1", "hide-when-no-apps": "1", "icon-invert-filter": "0", "icon-opacity": "100", "installed_version": "2.3.4", "loader-color": "#e6e6e6", "loader-enabled": "1", "opener": "side-menu-opener-hamburger", "opener-hover": "0", "opener-only": "0", "opener-position": "before", "show-settings": "0", "side-with-categories": "0", "size-icon": "big", "size-text": "big", "target-blank-apps": "[]", "text-color": "#ffffff", "top-menu-apps": "[]", "top-side-menu-apps": "[]", "types": "", "use-avatar": "0" } ``` ### Steps to reproduce Activate my configuration and you will see that when you try to click on the icon, when clicking a white square is displayed. ### Observed Results ... ### Expected Results That the square is not displayed

JordanDIG added the

bug

label 2022-04-08 18:22:07 +02:00

deblan referenced this issue from a commit

2022-04-10 18:56:58 +02:00

update opener active style (fix #99)

deblan added this to the v2.3.5 milestone 2022-04-10 18:59:24 +02:00

JordanDIG commented

2022-04-11 17:23:30 +02:00

Author

When do you plan to release the new version that incorporates this patch?

deblan closed this issue

2022-04-11 19:15:25 +02:00

deblan commented

2022-04-11 19:19:17 +02:00

Owner

v2.3.5 is released ;)

👍 1

JordanDIG commented

2022-04-11 22:30:54 +02:00

Author

The problem is solved on computer but on mobile we still have a square when we press the button @deblan

JordanDIG reopened this issue

2022-04-11 22:30:54 +02:00

deblan commented

2022-04-11 22:38:36 +02:00

Owner

The opener is the same on mobile. Do you have the problem when you resize your browser on desktop?

JordanDIG commented

2022-04-11 22:48:27 +02:00

Author

Yes i have the same problem..

The opener is the same on mobile. Do you have the problem when you resize your browser on desktop?

Yes i have the same problem.. > The opener is the same on mobile. Do you have the problem when you resize your browser on desktop?

deblan commented

2022-04-12 08:59:11 +02:00

Owner

For now, I can't reproduce the problem. Can you test with another browser to avoid cache issue?

JordanDIG commented

2022-04-12 09:29:32 +02:00

Author

For now, I can't reproduce the problem. Can you test with another browser to avoid cache issue?

The cache has been cleared but I still have the problem.

> For now, I can't reproduce the problem. Can you test with another browser to avoid cache issue? The cache has been cleared but I still have the problem.

JordanDIG commented

2022-04-12 09:30:31 +02:00

Author

Screen : https://s.jordand.fr/6qa9TdDdOY.mp4

deblan commented

2022-04-12 09:37:51 +02:00

Owner

Okay I understand. The white background has been replace with the current app background color for accessibility. All nextcloud buttons have a similar behaviour.

JordanDIG commented

2022-04-12 09:42:24 +02:00

Author

Oh okay

JordanDIG commented

2022-04-12 09:49:07 +02:00

Author

Okay I understand. The white background has been replace with the current app background color for accessibility. All nextcloud buttons have a similar behaviour.

So there's not much we can do about it?

> Okay I understand. The white background has been replace with the current app background color for accessibility. All nextcloud buttons have a similar behaviour. So there's not much we can do about it?

deblan commented

2022-04-12 10:07:50 +02:00

Owner

It is a voluntary behavior to help visually impaired people.

If you really want to remove it, you could install Custom CSS and use this CSS:

.side-menu-opener:not(.side-menu-closer):active, .side-menu-opener:not(.side-menu-closer):focus  {
    background: var(--side-menu-opener) !important;
}

It is a voluntary behavior to help visually impaired people. If you really want to remove it, you could install [Custom CSS](https://apps.nextcloud.com/apps/theming_customcss) and use this CSS: ``` .side-menu-opener:not(.side-menu-closer):active, .side-menu-opener:not(.side-menu-closer):focus { background: var(--side-menu-opener) !important; } ```

JordanDIG commented

2022-04-12 10:26:10 +02:00

Author

Thanks for all 👍

JordanDIG closed this issue

2022-04-12 10:26:11 +02:00

[BUG] White square #99

Issue

Environment

Steps to reproduce

Observed Results

Expected Results