deblan/side_menu
deblan/side_menu
4
11
Fork 9
Code Issues 20 Pull requests 3 Projects Releases 137 Wiki Activity

Update lib/AppInfo/Application.php #421

Merged
deblan merged 1 commit from Monica-Wood/side_menu:http_user_agent_check_patch into develop 2025-04-30 08:37:17 +02:00
Conversation 2 Commits 1 Files changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 8787918547 - Show all commits

Update lib/AppInfo/Application.php
Some checks are pending
ci/woodpecker/pr/build Pipeline is pending approval
Details
ci/woodpecker/pr/security Pipeline is pending approval
Details

Prev Next 
The current change is currently filling the nextcloud logs up with the error:
`Undefined array key \"HTTP_USER_AGENT\" at /srv/www/nextcloud/apps/side_menu/lib/AppInfo/Application.php#109`

This adds a check to ensure the index exists before read it.
Monica-Wood 2025-04-30 07:31:13 +02:00
commit 8787918547

2
lib/AppInfo/Application.php
View file

@ -106,7 +106,7 @@ class Application extends App implements IBootstrap
protected function isEnabled(): bool
{
if (preg_match('/MemoriesNative/', $_SERVER['HTTP_USER_AGENT'])) {
if (isset($_SERVER["HTTP_USER_AGENT"]) && preg_match('/MemoriesNative/', $_SERVER['HTTP_USER_AGENT'])) {
return false;
}