From bb48e715e7d4c37e988507f84a3b0ee3993dfb67 Mon Sep 17 00:00:00 2001 From: Simon Vieille Date: Mon, 6 May 2019 15:34:50 +0200 Subject: [PATCH] apply shellcheck --- bin/vacuum | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/bin/vacuum b/bin/vacuum index 10316f1..77635d3 100755 --- a/bin/vacuum +++ b/bin/vacuum @@ -1,7 +1,7 @@ #!/bin/sh usage() { - printf "Usage: %s [url] [filters] [-h|--help|--wget|--httrack]\n\n" $0 + printf "Usage: %s [url] [filters] [-h|--help|--wget|--httrack]\n\n" "$0" printf " --wget Select GNU Wget\n" printf " --httrack Select httrack to vacuum\n" @@ -13,11 +13,11 @@ usage() { TOOL= URL= -for i in $@; do - if [ "$i" = "-h" -o "$i" = "--help" ]; then +for i in "$@"; do + if [ "$i" = "-h" ] || [ "$i" = "--help" ]; then usage exit 0 - elif [ "$i" != "--httrack" -a "$i" != "--wget" ]; then + elif [ "$i" != "--httrack" ] && [ "$i" != "--wget" ]; then URL="$URL $i" elif [ "$i" = "--httrack" ]; then TOOL=httrack @@ -49,9 +49,9 @@ if [ -z "$TOOL" ]; then TOOL=1 fi - if [ "$TOOL" = "1" -o "$TOOL" = "httrack" ]; then + if [ "$TOOL" = "1" ] || [ "$TOOL" = "httrack" ]; then TOOL=httrack - elif [ "$TOOL" = "2" -o "$TOOL" = "wget" ]; then + elif [ "$TOOL" = "2" ] || [ "$TOOL" = "wget" ]; then TOOL=wget else TOOL= @@ -63,6 +63,6 @@ if [ "$TOOL" = "httrack" ]; then printf "\nCommand:\n\n httrack %s\n\n" "$URL" httrack $URL elif [ "$TOOL" = "wget" ]; then - printf "\nCommand:\n\n wget --progress=bar -E -r -k -np --no-check-certificate --user-agent=Firefox \"%s\"\n\n" $URL + printf "\nCommand:\n\n wget --progress=bar -E -r -k -np --no-check-certificate --user-agent=Firefox \"%s\"\n\n" "$URL" wget --progress=bar -E -r -k -np --no-check-certificate --user-agent=Firefox $URL fi