deblan/woodpecker-email
deblan/woodpecker-email
1
0
Fork 0
Code Issues 1 Pull requests Packages Projects Releases Wiki Activity

Support email notification without SMTP auth.

Browse source 
Even if .drone.yml does not specify username and password,
gomail.NewPlainDialer is still populated with them - albeit empty -
which means they are still being sent to SMTP server. In case of
Google's smtp-relay.gmail.com this will result in an error, even
if CI's server IP address is added to exclusion list allowing it to
skip auth entirely.

This commit constructs gomail.Dialer without username and password
if there was no username found in .drone.yml.

* Constructs gomail.Dialer without username when no username in .drone.yml
* Replaces gomail.NewPlainDialer with gomail.NewDialer
This commit is contained in:
Igor Ajdišek 2016-04-22 10:41:44 +02:00
parent 725e06f997
commit f5a7199254
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
sender.go
View file

@ -103,12 +103,21 @@ func send(subject, plainBody, htmlBody string, c *Context) error {
htmlBody,
)
d := gomail.NewPlainDialer(
c.Vargs.Host,
c.Vargs.Port,
c.Vargs.Username,
c.Vargs.Password,
)
var d *gomail.Dialer
if c.Vargs.Username == "" {
d = &gomail.Dialer{
Host: c.Vargs.Host,
Port: c.Vargs.Port,
SSL: c.Vargs.Port == 465,
}
} else {
d = gomail.NewDialer(
c.Vargs.Host,
c.Vargs.Port,
c.Vargs.Username,
c.Vargs.Password,
)
}
if c.Vargs.SkipVerify {
d.TLSConfig = &tls.Config{