Missing committer mail on Pull Request triggers #7
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
reproduced
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: deblan/woodpecker-email#7
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi,
after updating to the new version we have some problem with PR based pipeline runs.
This is an example config we use right now:
If the trigger of the pipeline is not a push event but a PR I get:
In the previous version that seemed to work and the last committers mail was used. Any idea how to fix that here, without disabling the mail plugin for Pull Request triggers?
Thanks!
Hi,
The mail of the author should be used. I push a new version (latest) of the plugin that includes a debugging option. Could you try it share the output of the plugin please?
The result may contain sensitive information, which should be deleted if necessary.
CI_COMMIT_AUTHOR_EMAIL
seems to be empty. Does the commiter have an email address?Yes, when I add another commit and push it I can see my mail address in the debug output and via
echo $CI_COMMIT_AUTHOR_EMAIL
in the pipeline. So somehow it is not set when running via as a PR type.The previous version of the project used
CI_COMMIT_AUTHOR_EMAIL
too. So the problem could be on Woodpecker or Gitea/Forgejo side.cli.StringFlag{
Name: "commit.author.email",
Usage: "git author email",
EnvVar: "CI_COMMIT_AUTHOR_EMAIL",
},
"CI_COMMIT_AUTHOR_EMAIL": p.Context.String("commit.author.email"),
if !p.Config.RecipientsOnly {
exists := false
for _, recipient := range p.Config.Recipients {
if recipient == p.Commit.Author.Email {
exists = true
}
}
if !exists {
p.Config.Recipients = append(p.Config.Recipients, p.Commit.Author.Email)
}
}
From Woodpecker matrix room:
After tests, the pull pull request webhook content contains the mail.
Same here, I can see the mail address in webhook content for pull requests.
https://github.com/woodpecker-ci/woodpecker/pull/3420
Fixed in https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.4.0