From 6d7543f381086b63a89cffd005a05da82c2ec6cb Mon Sep 17 00:00:00 2001
From: Simon Vieille <simon@deblan.fr>
Date: Fri, 4 Nov 2022 22:14:28 +0100
Subject: [PATCH] fix #164: open apps in new tab does not work

---
 src/AppMenu.vue         | 3 +++
 templates/js/script.php | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/AppMenu.vue b/src/AppMenu.vue
index 20fc9db..8f043e8 100644
--- a/src/AppMenu.vue
+++ b/src/AppMenu.vue
@@ -33,6 +33,7 @@
         <a :href="app.href"
           :class="{ 'has-unread': app.unread > 0 }"
           :aria-label="appLabel(app)"
+          :target="targetBlankApps.indexOf(app.id) !== -1 ? '_blank' : undefined"
           :aria-current="app.active ? 'page' : false">
           <img :src="app.icon" alt="">
           <div class="app-menu-entry--label">
@@ -75,6 +76,7 @@ export default {
       apps: null,
       appLimit: 0,
       observer: null,
+      targetBlankApps: [],
     }
   },
   mounted() {
@@ -93,6 +95,7 @@ export default {
       }
     })
 
+    this.targetBlankApps = window.targetBlankApps
     this.observer = new ResizeObserver(this.resize)
     this.observer.observe(this.$el)
     this.resize()
diff --git a/templates/js/script.php b/templates/js/script.php
index 797f013..2607866 100644
--- a/templates/js/script.php
+++ b/templates/js/script.php
@@ -22,10 +22,10 @@ if ($_['always-displayed']) {
   const nextcloud = document.querySelector('#nextcloud')
 
   const isTouchDevice = window.matchMedia("(pointer: coarse)").matches
-  const targetBlankApps = <?php echo json_encode($_['target-blank-apps']) ?>
 
+  window.targetBlankApps = <?php echo json_encode($_['target-blank-apps']), "\n" ?>
   window.topMenuApps = <?php echo json_encode($_['top-menu-apps']), "\n"; ?>
-  window.topSideMenuApps = <?php echo json_encode($_['top-side-menu-apps'])."\n"; ?>
+  window.topSideMenuApps = <?php echo json_encode($_['top-side-menu-apps']), "\n"; ?>
   window.menuAppsOrder = <?php echo json_encode($_['apps-order']), "\n"; ?>
 
   <?php if ($display === 'big-menu'): ?>