From b287b671be6f558f882464f36bc91f7e13c2fdb9 Mon Sep 17 00:00:00 2001
From: Simon Vieille <simon@deblan.fr>
Date: Sun, 6 Apr 2025 14:09:06 +0200
Subject: [PATCH] add mount of menu

fix store usage

add page loader
---
 package.json                                  |  2 +-
 src/PageLoader.js                             | 20 -----
 src/components/AdminCategoriesCustom.vue      | 10 ++-
 src/components/AppSearch.vue                  |  2 +-
 src/components/PageLoader.vue                 | 24 +++++
 src/lib/dom.js                                | 14 +--
 src/lib/search.js                             |  9 +-
 src/menu.js                                   | 44 ++++------
 src/menus/MenuContainer.vue                   | 87 +++++++++++++++++++
 .../{SideMenu.vue => SimpleSideMenu.vue}      | 19 ++--
 .../{SideMenuBig.vue => TopWideMenu.vue}      |  0
 src/store/config.js                           |  8 +-
 src/store/nav.js                              | 14 ++-
 templates/js/script.php                       |  2 +-
 webpack.config.js                             |  1 +
 15 files changed, 175 insertions(+), 81 deletions(-)
 delete mode 100644 src/PageLoader.js
 create mode 100644 src/components/PageLoader.vue
 create mode 100644 src/menus/MenuContainer.vue
 rename src/menus/{SideMenu.vue => SimpleSideMenu.vue} (92%)
 rename src/menus/{SideMenuBig.vue => TopWideMenu.vue} (100%)

diff --git a/package.json b/package.json
index 877b484..fb48ac4 100644
--- a/package.json
+++ b/package.json
@@ -28,7 +28,7 @@
     "@nextcloud/browserslist-config": "^3.0.1",
     "@nextcloud/event-bus": "^3.3.1",
     "@nextcloud/initial-state": "^2.2.0",
-    "@nextcloud/l10n": "^3.1.0",
+    "@nextcloud/l10n": "^3.2.0",
     "babel-loader": "^9.1.3",
     "css-loader": "^7.1.2",
     "eslint": "^9.19.0",
diff --git a/src/PageLoader.js b/src/PageLoader.js
deleted file mode 100644
index 291976e..0000000
--- a/src/PageLoader.js
+++ /dev/null
@@ -1,20 +0,0 @@
-const createElement = require('./lib/createElement')
-
-const PageLoader = () => {
-  const pageLoader = createElement('div', { id: 'side-menu-loader' })
-  const pageLoaderBar = createElement('div', { id: 'side-menu-loader-bar' })
-
-  pageLoader.appendChild(pageLoaderBar)
-  document.querySelector('body').appendChild(pageLoader)
-
-  let pageLoaderValue = 0
-
-  window.addEventListener('beforeunload', () => {
-    setInterval(() => {
-      pageLoaderBar.style.width = pageLoaderValue.toString() + '%'
-      pageLoaderValue = Math.min(pageLoaderValue + 0.2, 100)
-    }, 25)
-  })
-}
-
-module.exports = PageLoader
diff --git a/src/components/AdminCategoriesCustom.vue b/src/components/AdminCategoriesCustom.vue
index 11bb4d7..407ae06 100644
--- a/src/components/AdminCategoriesCustom.vue
+++ b/src/components/AdminCategoriesCustom.vue
@@ -42,7 +42,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
       @close="hideAddForm"
     >
       <div class="modal__content">
-        <div v-for="(lang, key) in langs" :key="key">
+        <div
+          v-for="(lang, key) in langs"
+          :key="key"
+        >
           <span class="lang">{{ lang }}</span>
           <input
             v-model="newValue[lang]"
@@ -66,7 +69,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
       @close="hideEditForm"
     >
       <div class="modal__content">
-        <div v-for="(lang, key) in langs" :key="key">
+        <div
+          v-for="(lang, key) in langs"
+          :key="key"
+        >
           <span class="lang">{{ lang }}</span>
           <input
             v-model="editValue[lang]"
diff --git a/src/components/AppSearch.vue b/src/components/AppSearch.vue
index a4dd6d6..7f7a17f 100644
--- a/src/components/AppSearch.vue
+++ b/src/components/AppSearch.vue
@@ -26,7 +26,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 </template>
 
 <script setup>
-const emit = defineEmit('input')
+const emit = defineEmits('input')
 const { value } = defineProps({
   value: {
     type: String,
diff --git a/src/components/PageLoader.vue b/src/components/PageLoader.vue
new file mode 100644
index 0000000..95ded5e
--- /dev/null
+++ b/src/components/PageLoader.vue
@@ -0,0 +1,24 @@
+<template>
+  <div id="side-menu-loader">
+    <div id="side-menu-loader-bar" :style="createStyle(width)"></div>
+  </div>
+</template>
+
+<script setup>
+import { onMounted, ref } from 'vue'
+
+const width = ref(0)
+const createStyle = (size) => {
+  return {
+    width: `${size}%`,
+  }
+}
+
+onMounted(() => {
+  window.addEventListener('beforeunload', () => {
+    setInterval(() => {
+      width.value = Math.min(width.value + 0.2, 100)
+    }, 25)
+  })
+})
+</script>
diff --git a/src/lib/dom.js b/src/lib/dom.js
index 99081f7..f1e6913 100644
--- a/src/lib/dom.js
+++ b/src/lib/dom.js
@@ -1,11 +1,13 @@
 const waitContainer = async (selector) => {
-  new Promise((resolve) => {
-    setTimeout(() => {
-      const container = document.querySelector(selector)
+  return new Promise((resolve) => {
+    const container = document.querySelector(selector)
 
-      if (container) {
-        resolve(selector, container)
-      }
+    if (container) {
+      return resolve(selector, container)
+    }
+
+    setTimeout(() => {
+      waitContainer(selector)
     }, 50)
   })
 }
diff --git a/src/lib/search.js b/src/lib/search.js
index fed40d2..4fee589 100644
--- a/src/lib/search.js
+++ b/src/lib/search.js
@@ -13,14 +13,11 @@ const containsAppsMatchingSearch = (values, search) => {
 }
 
 const isAppMatchingSearch = (item, search) => {
-  if (search.value.trim() === '') {
+  if (search.trim() === '') {
     return true
   }
 
-  return item.name.toLowerCase().includes(search.value.trim().toLowerCase())
+  return item.name.toLowerCase().includes(search.trim().toLowerCase())
 }
 
-export {
-  containsAppsMatchingSearch,
-  isAppMatchingSearch,
-}
+export { containsAppsMatchingSearch, isAppMatchingSearch }
diff --git a/src/menu.js b/src/menu.js
index c3dd834..b9842c0 100644
--- a/src/menu.js
+++ b/src/menu.js
@@ -19,39 +19,29 @@ import './scss/menu.scss'
 
 import { createApp } from 'vue'
 import { createPinia } from 'pinia'
-import { waitContainer } from './lib/dom.js'
+import { createElement } from './lib/dom.js'
 
-// import AppMenu from './menus/AppMenu.vue'
-import SideMenu from './menus/SideMenu.vue'
-import SideMenuBig from './menus/SideMenuBig.vue'
-import SideMenuWithCategories from './menus/SideMenuWithCategories.vue'
+import MenuContainer from './menus/MenuContainer.vue'
 
 // import PageLoader from './components/PageLoader.vue'
-
 // window.PageLoader = PageLoader
 
 const pinia = createPinia()
-
-waitContainer('#side-menu').then((selector, container) => {
-  const component = (() => {
-    if (container.getAttribute('data-bigmenu')) {
-      return SideMenuBig
-    } else if (container.getAttribute('data-sidewithcategories')) {
-      return SideMenuWithCategories
-    } else {
-      return SideMenu
-    }
-  })()
-
-  const app = createApp(component)
-
-  app.use(pinia)
-  app.mount(selector)
+const body = document.querySelector('body')
+const container = createElement('div', {
+  id: 'side-menu-container',
 })
 
-waitContainer('#header .app-menu').then((selector) => {
-  const app = createApp(AppMenu)
+body.appendChild(container)
 
-  app.use(pinia)
-  app.mount(selector)
-})
+const app = createApp(MenuContainer)
+app.use(pinia)
+app.mixin({ methods: { t, n }})
+app.mount(container)
+
+// waitContainer('#header .app-menu').then((selector) => {
+//   const app = createApp(AppMenu)
+//   app.use(pinia)
+//   app.mixin({ methods: { t, n }})
+//   app.mount(selector)
+// })
diff --git a/src/menus/MenuContainer.vue b/src/menus/MenuContainer.vue
new file mode 100644
index 0000000..1a3137c
--- /dev/null
+++ b/src/menus/MenuContainer.vue
@@ -0,0 +1,87 @@
+<template>
+  <template v-if="display">
+    <PageLoader v-if="hasPageLoader" />
+    <TopWideMenu v-if="display === 'big-menu'" />
+    <SideMenuWithCategories v-else-if="display === 'side-with-categories'" />
+    <SimpleSideMenu
+      v-else-if="display === 'simple-side-menu'"
+      :alawayDisplayed="display === 'always-displayed'"
+    />
+  </template>
+</template>
+
+<script setup>
+import { ref, onMounted } from 'vue'
+import { useConfigStore } from '../store/config.js'
+import { createElement } from '../lib/dom.js'
+import { translate as t } from '@nextcloud/l10n'
+
+import SimpleSideMenu from './SimpleSideMenu'
+import TopWideMenu from './TopWideMenu'
+import SideMenuWithCategories from './SideMenuWithCategories'
+import PageLoader from '../components/PageLoader'
+
+const config = ref(null)
+const configStore = useConfigStore()
+const display = ref(null)
+const alawayDisplayed = ref(false)
+const hasPageLoader = ref(false)
+const createOpener = () => {
+  const nextcloud = document.querySelector('#nextcloud')
+  const logo = document.querySelector('.header-left .logo, .header-start .logo')
+
+  if (!nextcloud || !logo) {
+    return
+  }
+
+  if (logo.parentNode !== nextcloud) {
+    nextcloud.appendChild(logo)
+  }
+
+  const opener = createElement('button', {
+    'class': 'side-menu-opener',
+    'arial-label': t('side_menu', 'Toggle the menu'),
+    'html': `<span>${t('side_menu', 'Toggle the menu')}</span>`
+  })
+
+  if (config.value['opener-position'] === 'before') {
+    nextcloud.parentNode.insertBefore(opener, nextcloud)
+  } else {
+    nextcloud.parentNode.insertBefore(opener, nextcloud.nextSibling)
+  }
+}
+
+const createLoader = () => {
+  const loader = createElement('div', { id: 'side-menu-loader' })
+  const bar = createElement('div', { id: 'side-menu-loader-bar' })
+
+  loader.appendChild(bar)
+  document.querySelector('body').appendChild(loader)
+
+  let pageLoaderValue = 0
+
+  window.addEventListener('beforeunload', () => {
+    setInterval(() => {
+      pageLoaderBar.style.width = pageLoaderValue.toString() + '%'
+      pageLoaderValue = Math.min(pageLoaderValue + 0.2, 100)
+    }, 25)
+  })
+}
+
+onMounted(async () => {
+  config.value = await configStore.getConfig()
+
+  if (config.value['big-menu']) {
+    display.value = 'big-menu'
+  } else if (config.value['side-with-categories']) {
+    display.value = 'side-with-categories'
+  } else {
+    display.value = 'simple-side-menu'
+    alawayDisplayed.value = config.value['always-displayed']
+  }
+
+  hasPageLoader.value = config.value['loader-enabled']
+
+  createOpener()
+})
+</script>
diff --git a/src/menus/SideMenu.vue b/src/menus/SimpleSideMenu.vue
similarity index 92%
rename from src/menus/SideMenu.vue
rename to src/menus/SimpleSideMenu.vue
index 7b9522e..cfe0ee1 100644
--- a/src/menus/SideMenu.vue
+++ b/src/menus/SimpleSideMenu.vue
@@ -17,8 +17,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 <template>
   <div id="side-menu">
     <div
-      class="side-menu-header"
       v-if="settings || !openerHover || (!avatar && !alwaysDisplayed && logo) || avatar"
+      class="side-menu-header"
     >
       <SettingsButton
         v-if="settings"
@@ -75,6 +75,8 @@ import SideMenuApp from '../components/SideMenuApp'
 import AppSearch from '../components/AppSearch'
 import Logo from '../components/Logo'
 
+const navStore = useNavStore()
+const configStore = useConfigStore()
 const targetBlankApps = ref(null)
 const forceLightIcon = ref(null)
 const avatar = ref(null)
@@ -86,12 +88,7 @@ const alwaysDisplayed = ref(null)
 const search = ref('')
 const apps = ref([])
 
-function getFiltredAndSortedApps(
-  items,
-  order,
-  topMenuApps,
-  topSideMenuApps
-) {
+function getFiltredAndSortedApps(items, order, topMenuApps, topSideMenuApps) {
   const data = []
 
   items.forEach((item) => {
@@ -115,8 +112,8 @@ function getFiltredAndSortedApps(
   })
 }
 
-onMounted(() => {
-  const config = useConfigStore.getConfig()
+onMounted(async () => {
+  const config = await configStore.getConfig()
 
   targetBlankApps.value = config['target-blank-apps']
   forceLightIcon.value = config['force-light-icon']
@@ -128,10 +125,10 @@ onMounted(() => {
   alwaysDisplayed.value = config['always-displayed']
 
   apps.value = getFiltredAndSortedApps(
-    useNavStore.getApps(),
+    await navStore.getApps(),
     config['apps-order'],
     config['top-menu-apps'],
-    config['top-side-menu-apps'],
+    config['top-side-menu-apps']
   )
 })
 </script>
diff --git a/src/menus/SideMenuBig.vue b/src/menus/TopWideMenu.vue
similarity index 100%
rename from src/menus/SideMenuBig.vue
rename to src/menus/TopWideMenu.vue
diff --git a/src/store/config.js b/src/store/config.js
index f7af5e9..29c5693 100644
--- a/src/store/config.js
+++ b/src/store/config.js
@@ -1,6 +1,6 @@
 import { defineStore } from 'pinia'
 import { ref } from 'vue'
-import { axios } from '@nextcloud/axios'
+import axios from '@nextcloud/axios'
 import { generateUrl } from '@nextcloud/router'
 
 export const useConfigStore = defineStore('config', () => {
@@ -11,8 +11,12 @@ export const useConfigStore = defineStore('config', () => {
       return config.value
     }
 
-    config.value = await fetch(generateUrl('/apps/side_menu/js/config')).then((response) => response.data)
+    config.value = await axios.get(generateUrl('/apps/side_menu/js/config')).then((response) => response.data)
 
     return config.value
   }
+
+  return {
+    getConfig,
+  }
 })
diff --git a/src/store/nav.js b/src/store/nav.js
index 52f1d77..891f2a7 100644
--- a/src/store/nav.js
+++ b/src/store/nav.js
@@ -1,20 +1,21 @@
 import { defineStore } from 'pinia'
 import { ref } from 'vue'
-import { axios } from '@nextcloud/axios'
+import axios from '@nextcloud/axios'
 import { generateUrl } from '@nextcloud/router'
 
 export const useNavStore = defineStore('nav', () => {
   const categories = ref(null)
   const apps = ref(null)
 
-  function getApps() {
+  async function getApps() {
     if (apps.value !== null) {
       return apps.value
     }
 
     apps.value = []
+    const cats = await getCategories()
 
-    getCategories().forEach((category) => {
+    cats.forEach((category) => {
       Object.values(category.apps).forEach((app) => {
         apps.value.push(app)
       })
@@ -28,8 +29,13 @@ export const useNavStore = defineStore('nav', () => {
       return categories.value
     }
 
-    categories.value = await fetch(generateUrl('/apps/side_menu/nav/items')).then((response) => response.data.items)
+    categories.value = await axios.get(generateUrl('/apps/side_menu/nav/items')).then((response) => response.data.items)
 
     return categories.value
   }
+
+  return {
+    getApps,
+    getCategories,
+  }
 })
diff --git a/templates/js/script.php b/templates/js/script.php
index f623d8f..406c672 100644
--- a/templates/js/script.php
+++ b/templates/js/script.php
@@ -187,7 +187,7 @@ const SMcreateElement = (tagName, attributes) => {
   sideMenuContainer.appendChild(sideMenu)
 
   <?php if ($_['loader-enabled'] === true): ?>
-    PageLoader()
+    // PageLoader()
   <?php endif; ?>
 
   if (nextcloud) {
diff --git a/webpack.config.js b/webpack.config.js
index 7394e49..c9ca6de 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -13,6 +13,7 @@ const isDev = buildMode === 'development'
 module.exports = {
   target: 'web',
   mode: buildMode,
+  devtool: "inline-source-map",
   entry: {
     menu: path.resolve(path.join('src', 'menu.js')),
     // admin: path.resolve(path.join('src', 'admin.js')),