From c65cc26be8f130cc0b191558cff4e4f6091933c6 Mon Sep 17 00:00:00 2001
From: Simon Vieille <simon.vieille@trinaps.com>
Date: Thu, 12 Oct 2023 15:27:36 +0200
Subject: [PATCH] batch form is not submitted with XHR when it's a global
 action

---
 src/core/Resources/assets/js/modules/batch.js | 28 +++++++++++++------
 .../views/admin/crud/index.html.twig          |  9 ++++--
 2 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/src/core/Resources/assets/js/modules/batch.js b/src/core/Resources/assets/js/modules/batch.js
index 2d5c1f2..9e11c9f 100644
--- a/src/core/Resources/assets/js/modules/batch.js
+++ b/src/core/Resources/assets/js/modules/batch.js
@@ -8,16 +8,28 @@ module.exports = () => {
   const form = $('#form-batch')
 
   form.submit((e) => {
-    e.preventDefault()
+    const select = document.querySelector('#form-batch-action')
+    const options = select.querySelectorAll('#form-batch-action option')
+    let doPrevent = true
 
-    const route = form.attr('action')
-    const datas = form.serialize()
+    options.forEach((option) => {
+      if (option.value === select.value && option.getAttribute('data-isglobal') === 'true') {
+        doPrevent = false
+      }
+    })
 
-    form.addClass('is-loading')
+    if (doPrevent) {
+      e.preventDefault()
 
-    $.post(route, datas)
-      .always(() => {
-        document.location.reload()
-      })
+      const route = form.attr('action')
+      const datas = form.serialize()
+
+      form.addClass('is-loading')
+
+      $.post(route, datas)
+        .always(() => {
+          document.location.reload()
+        })
+    }
   })
 }
diff --git a/src/core/Resources/views/admin/crud/index.html.twig b/src/core/Resources/views/admin/crud/index.html.twig
index cdf4cc0..d8e17f9 100644
--- a/src/core/Resources/views/admin/crud/index.html.twig
+++ b/src/core/Resources/views/admin/crud/index.html.twig
@@ -283,15 +283,18 @@
 
                                             {% if configuration.hasBatchAction(context) %}
                                                 <div class="mb-2">
-                                                    <form class="form-inline" action="{{ path(configuration.pageRoute('batch'), {page: pager.currentPageNumber}|merge(configuration.pageRouteParams('batch'))) }}" id="form-batch" method="POST">
+                                                    <form class="form-inline" action="{{ path(configuration.pageRoute('batch'), {
+                                                        page: pager.currentPageNumber,
+                                                        redirectTo: app.request.uri
+                                                    }|merge(configuration.pageRouteParams('batch'))) }}" id="form-batch" method="POST">
                                                         <select class="form-control my-1 mr-sm-2" name="batch[target]">
                                                             <option value="selection">{{ 'For selection'|trans }}</option>
                                                             <option value="all">{{ 'For all items'|trans }}</option>
                                                         </select>
-                                                        <select class="form-control my-1 mr-sm-2" name="batch[action]">
+                                                        <select class="form-control my-1 mr-sm-2" id="form-batch-action" name="batch[action]">
                                                             <option value=""></option>
                                                             {% for action, conf in configuration.batchActions(context) %}
-                                                                <option value="{{ action }}">
+                                                                <option value="{{ action }}" {% if conf.isGlobal %}data-isglobal="true"{% endif %}>
                                                                     {{ conf.label|trans }}
                                                                 </option>
                                                             {% endfor %}