Add npm run lint to CI and to docs

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
This commit is contained in:
Thomas Citharel 2019-03-22 11:04:57 +01:00
parent b698eb470f
commit 1309fdd3da
No known key found for this signature in database
GPG key ID: A061B9DDE0CA0773
2 changed files with 18 additions and 1 deletions

View file

@ -53,6 +53,19 @@ js_deps:
- js/node_modules
allow_failure: true
js_check:
stage: front
before_script:
- cd js
- npm install
script:
- npm run lint
after_script:
- cd ../
cache:
paths:
- js/node_modules
elixir_check:
stage: back
before_script:

View file

@ -4,7 +4,7 @@
We format our code with the Elixir Formatter and check for issues with [Credo](https://github.com/rrrene/credo) (a few rules are not blocking).
Please run those two commands before pushing code :
Please run those two commands before pushing code:
* `mix format`
* `mix credo`
@ -15,4 +15,8 @@ These two commands must not return an error code, since they are required to pas
We use `tslint` with the `tslint-config-airbnb` preset.
Errors should be reported when running in dev mode `npm run dev` or when building a production bundle `npm run build`.
Please run the following command before pushing code `npm run lint`.
This command must not return an error code, since it's required to pass inside CI.
We also try to follow the [official Vue.js style guide](https://vuejs.org/v2/style-guide/).