deblan-mirror/Choices
deblan-mirror/Choices
1
0
Fork 0
mirror of https://github.com/Choices-js/Choices.git synced 2024-05-17 13:06:34 +02:00
Code Issues Projects Releases Wiki Activity

Remove assignment within if

Browse source
This commit is contained in:
Josh Johnson 2017-08-14 13:33:20 +01:00
parent bfef79d3ee
commit e16ddb404f
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
assets/scripts/src/choices.js
View file

@ -1,6 +1,6 @@
import Fuse from 'fuse.js'; import Fuse from 'fuse.js';
import classNames from 'classnames'; import classNames from 'classnames';
import Store from './store/index.js'; import Store from './store/index';
import { import {
addItem, addItem,
removeItem, removeItem,
@ -1875,16 +1875,19 @@ class Choices {
} }
if (this.containerOuter.contains(target) && target !== this.input) { if (this.containerOuter.contains(target) && target !== this.input) {
let foundTarget;
const activeItems = this.store.getItemsFilteredByActive(); const activeItems = this.store.getItemsFilteredByActive();
const hasShiftKey = e.shiftKey; const hasShiftKey = e.shiftKey;
if (foundTarget = findAncestorByAttrName(target, 'data-button')) { const buttonTarget = findAncestorByAttrName(target, 'data-button');
this._handleButtonAction(activeItems, foundTarget); const itemTarget = findAncestorByAttrName(target, 'data-item');
} else if (foundTarget = findAncestorByAttrName(target, 'data-item')) { const choiceTarget = findAncestorByAttrName(target, 'data-choice');
this._handleItemAction(activeItems, foundTarget, hasShiftKey);
} else if (foundTarget = findAncestorByAttrName(target, 'data-choice')) { if (buttonTarget) {
this._handleChoiceAction(activeItems, foundTarget); this._handleButtonAction(activeItems, buttonTarget);
} else if (itemTarget) {
this._handleItemAction(activeItems, itemTarget, hasShiftKey);
} else if (choiceTarget) {
this._handleChoiceAction(activeItems, choiceTarget);
} }
e.preventDefault(); e.preventDefault();