deblan-mirror/abraunegg-onedrive
deblan-mirror/abraunegg-onedrive
1
0
Fork 0
mirror of https://github.com/abraunegg/onedrive synced 2024-05-17 21:26:41 +02:00
Code Issues Projects Releases Wiki Activity

Catch errors from OneDrive when initialising subscriptions (#1846)

Browse source 
* Catch errors from OneDrive when initialising subscriptions
This commit is contained in:
abraunegg 2022-03-06 10:02:14 +11:00 committed by GitHub
parent 7ff077efd8
commit 76bd6e26a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
docs/USAGE.md
View file

@ -745,22 +745,22 @@ webhook_enabled = "true"
webhook_public_url = "<public-facing url to reach your webhook>" webhook_public_url = "<public-facing url to reach your webhook>"
``` ```
Setting `webhook_enabled` to `true` enables the webhook in 'monitor' mode. The onedrive process will listen for incoming updates at a configurable endpoint, which defaults to `0.0.0.0:8888`. The `webhook_public_url` must be set to an public-facing url for Microsoft to send updates to your webhook. If your host is directly exposed to the Internet, the `webhook_public_url` can be set to `http://<your_host>:8888/` to match the default endpoint. However, the recommended approach is to configure a reverse proxy like nginx. Setting `webhook_enabled` to `true` enables the webhook in 'monitor' mode. The onedrive process will listen for incoming updates at a configurable endpoint, which defaults to `0.0.0.0:8888`. The `webhook_public_url` must be set to an public-facing url for Microsoft to send updates to your webhook. If your host is directly exposed to the Internet, the `webhook_public_url` can be set to `http://<your_host_ip>:8888/` to match the default endpoint. However, the recommended approach is to configure a reverse proxy like nginx.
**Note:** A valid HTTPS certificate is required for your public-facing URL if using nginx.
For example, below is a nginx config snippet to proxy traffic into the webhook: For example, below is a nginx config snippet to proxy traffic into the webhook:
``` ```
http { server {
server { listen 80;
listen 80; location /webhooks/onedrive {
location /webhooks/onedrive { proxy_pass http://127.0.0.1:8888;
proxy_pass http://127.0.0.1:8888; }
}
}
} }
``` ```
With nginx running, you can configure `webhook_public_url` to `http://<your_host>/webhooks/onedrive`. With nginx running, you can configure `webhook_public_url` to `https://<your_host>/webhooks/onedrive`.
### More webhook configuration options ### More webhook configuration options

12
src/onedrive.d
View file

@ -1004,7 +1004,17 @@ final class OneDriveApi
"clientState": randomUUID().toString() "clientState": randomUUID().toString()
]; ];
http.addRequestHeader("Content-Type", "application/json"); http.addRequestHeader("Content-Type", "application/json");
JSONValue response = post(url, request.toString()); JSONValue response;
try {
response = post(url, request.toString());
} catch (OneDriveException e) {
displayOneDriveErrorMessage(e.msg, getFunctionName!({}));
// We need to exit here, user needs to fix issue
log.error("ERROR: Unable to initialize subscriptions for updates. Please fix this issue.");
exit(-1);
}
// Save important subscription metadata including id and expiration // Save important subscription metadata including id and expiration
subscriptionId = response["id"].str; subscriptionId = response["id"].str;