mirror of
https://github.com/andres-montanez/Magallanes
synced 2024-06-16 12:35:04 +02:00
minor phpdoc fix, test string fixed for unknown task class
This commit is contained in:
parent
2c27e2c46d
commit
1acffae330
|
@ -30,7 +30,7 @@ class Factory
|
||||||
* @param boolean $inRollback
|
* @param boolean $inRollback
|
||||||
* @param string $stage
|
* @param string $stage
|
||||||
* @return \Mage\Task\AbstractTask
|
* @return \Mage\Task\AbstractTask
|
||||||
* @throws \Exception|\Mage\Task\ErrorWithMessageException
|
* @throws \Exception
|
||||||
*/
|
*/
|
||||||
public static function get($taskData, Config $taskConfig, $inRollback = false, $stage = null)
|
public static function get($taskData, Config $taskConfig, $inRollback = false, $stage = null)
|
||||||
{
|
{
|
||||||
|
|
|
@ -30,6 +30,15 @@ class FactoryTest extends PHPUnit_Framework_TestCase
|
||||||
$this->assertInstanceOf('\\Mage\\Task\\AbstractTask', $task);
|
$this->assertInstanceOf('\\Mage\\Task\\AbstractTask', $task);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @dataProvider taskDataProvider
|
||||||
|
*/
|
||||||
|
public function testGetWith($taskData)
|
||||||
|
{
|
||||||
|
$task = Factory::get($taskData, $this->config);
|
||||||
|
$this->assertInstanceOf('\\Mage\\Task\\AbstractTask', $task);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @expectedException \Exception
|
* @expectedException \Exception
|
||||||
* @expectedExceptionMessage The Task MyInconsistentTask must be an instance of Mage\Task\AbstractTask.
|
* @expectedExceptionMessage The Task MyInconsistentTask must be an instance of Mage\Task\AbstractTask.
|
||||||
|
@ -45,7 +54,7 @@ class FactoryTest extends PHPUnit_Framework_TestCase
|
||||||
*/
|
*/
|
||||||
public function testGetClassDoesNotExist()
|
public function testGetClassDoesNotExist()
|
||||||
{
|
{
|
||||||
Factory::get('notknowntask', $this->config);
|
Factory::get('unknowntask', $this->config);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in a new issue