13 commits

Author	SHA1	Message	Date
Henrique Moody	c30603759e	Apply "SlevomatCodingStandard.TypeHints.TypeHintDeclaration" ... Signed-off-by: Henrique Moody <henriquemoody@gmail.com>	2019-02-09 14:09:28 +01:00
Henrique Moody	c99f3818b7	Use variadics "AbstractFilterRule" rule ... Since the library doesn't need to give support to version 5.4 or less of PHP using variadics in the constructor of "AbstractFilterRule" seems better than doing the whole validation. This commit will also apply the contribution guidelines to "AbstractFilterRule" and use a better naming for it. Signed-off-by: Henrique Moody <henriquemoody@gmail.com>	2018-10-15 09:41:01 +02:00
Henrique Moody	9283c8ecd9	Do not accept whitespace by default in "Digit" rule ... The "Digit" rule is meant to validate digits. However, by default, it also considers any whitespace character (spaces, new lines, tabs, etc) as valid. Since the rule also accepts a list of characters to ignore during the validation it seemed logical to me to leave the responsibility of allowing whitespace characters on the hands of the one who uses the rule. The messages of the exception are not really consistent, this commit will also fix that. It's also clear that the "AbstractCtypeRule" is an unnecessary overhead since it is only a proxy for "AbstractFilterRule". That one can and should even be removed after this commit is applied especially because this commit will also remove the method "filterWhiteSpaceOption" which is the only substantial difference between "AbstractCtypeRule" and "AbstractFilterRule". This commit will also apply our guidelines to the "Digit" rule since we want to do that to all the rules we have. Signed-off-by: Henrique Moody <henriquemoody@gmail.com>	2018-09-12 10:00:17 +02:00
Henrique Moody	e044e4b16e	Add some code standards for PHPUnit tests ... Signed-off-by: Henrique Moody <henriquemoody@gmail.com>	2018-07-23 20:46:18 +02:00
Henrique Moody	c80524b457	Method assert() should not have a return value ... One this method should throw an exception when the input is not valid, returning `TRUE` when it succeeds is not really consistent.	2018-01-28 17:38:40 +01:00
Henrique Moody	ef975629f3	Changes on PHP-CS-Fixer configuration ... Because of `declare(strict_types=1)` some changes were necessary.	2018-01-04 17:59:37 +01:00
Henrique Moody	fa030637cc	Fix wrong call to PHPUnit assertions ... The assertion methods are all static, therefore they should be called with self::assert* instead of $this->assert*.	2017-11-12 14:35:19 +01:00
Gabriel Caruso	93ce9cb93a	Updated to PHPUnit 6	2017-11-12 14:22:22 +01:00
Henrique Moody	d67394cd39	Escape fully qualified class names	2017-02-04 14:01:14 +01:00
Henrique Moody	9c49dd3bcf	Use short array syntax	2015-10-17 22:56:32 -03:00
Henrique Moody	3e45647b81	Make all rules mandatory	2015-10-07 01:00:39 -03:00
Henrique Moody	757c3776af	Add @covers and @group rule on rule tests	2015-08-16 15:00:05 -03:00
Henrique Moody	02a1923eb5	Move unit tests to "tests/unit"	2015-08-11 13:36:25 -03:00

Renamed from tests/Rules/DigitTest.php (Browse further)