deblan-mirror/wails
1
0
Fork 0
mirror of https://github.com/wailsapp/wails.git synced 2026-03-14 14:45:49 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix window visibility issue #2861 - initialize showRequested based on Hidden option

Browse source
This commit is contained in:
Lea Anthony 2025-07-06 15:55:36 +10:00
commit 504d456dea
No known key found for this signature in database
GPG key ID: 33DAF7BB90A58405
2 changed files with 33 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

46
v3/internal/commands/tool_package.go
View file

@ -7,7 +7,7 @@ import (
"runtime"
"strings"
"github.com/wailsapp/wails/v3/internal/commands/dmg"
// "github.com/wailsapp/wails/v3/internal/commands/dmg" // TODO: Missing package
"github.com/wailsapp/wails/v3/internal/flags"
"github.com/wailsapp/wails/v3/internal/packager"
)
@ -43,30 +43,34 @@ func ToolPackage(options *flags.ToolPackage) error {
// Create output path for DMG
dmgPath := filepath.Join(options.Out, fmt.Sprintf("%s.dmg", options.ExecutableName))
// Create DMG creator
dmgCreator, err := dmg.New(appPath, dmgPath, options.ExecutableName)
if err != nil {
return fmt.Errorf("error creating DMG: %w", err)
}
// DMG creation temporarily disabled - missing dmg package
_ = dmgPath // avoid unused variable warning
return fmt.Errorf("DMG creation is temporarily disabled due to missing dmg package")
// // Create DMG creator
// dmgCreator, err := dmg.New(appPath, dmgPath, options.ExecutableName)
// if err != nil {
// return fmt.Errorf("error creating DMG: %w", err)
// }
// Set background image if provided
if options.BackgroundImage != "" {
if err := dmgCreator.SetBackgroundImage(options.BackgroundImage); err != nil {
return fmt.Errorf("error setting background image: %w", err)
}
}
// // Set background image if provided
// if options.BackgroundImage != "" {
// if err := dmgCreator.SetBackgroundImage(options.BackgroundImage); err != nil {
// return fmt.Errorf("error setting background image: %w", err)
// }
// }
// Set default icon positions
dmgCreator.AddIconPosition(filepath.Base(appPath), 150, 175)
dmgCreator.AddIconPosition("Applications", 450, 175)
// // Set default icon positions
// dmgCreator.AddIconPosition(filepath.Base(appPath), 150, 175)
// dmgCreator.AddIconPosition("Applications", 450, 175)
// Create the DMG
if err := dmgCreator.Create(); err != nil {
return fmt.Errorf("error creating DMG: %w", err)
}
// // Create the DMG
// if err := dmgCreator.Create(); err != nil {
// return fmt.Errorf("error creating DMG: %w", err)
// }
fmt.Printf("DMG created successfully: %s\n", dmgPath)
return nil
// fmt.Printf("DMG created successfully: %s\n", dmgPath)
// return nil
}
// For Linux packages, continue with existing logic

4
v3/pkg/application/webview_window_windows.go
View file

@ -271,6 +271,10 @@ func (w *windowsWebviewWindow) run() {
options := w.parent.options
// Initialize showRequested based on whether window should be hidden
// Non-hidden windows should be shown by default
w.showRequested = !options.Hidden
w.chromium = edge.NewChromium()
if globalApplication.options.ErrorHandler != nil {
w.chromium.SetErrorCallback(globalApplication.options.ErrorHandler)