Enhance inputCloned text input with type and name (#908)

* Enhance inputCloned text input with type and name

Safari will display a contact autocomplete on every text input which `name` attribute contains "*name*" or does not have any `name` attribute.
Adding a fine tuned `name`attribute to the input should prevent that.

Plus, input type="search" seems more suited to the field intent (https://developer.mozilla.org/fr/docs/Web/HTML/Element/Input/search).

* Adapt inputCloned related test
This commit is contained in:
Bob Maerten 2021-12-22 22:56:04 +01:00 committed by GitHub
parent b92823b70c
commit 82b94228f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions

View file

@ -494,7 +494,8 @@ describe('templates', () => {
*/
const expectedOutput = strToEl(`
<input
type="text"
type="search"
name="search_terms"
class="${classes.input} ${classes.inputCloned}"
autocomplete="off"
role="textbox"

View file

@ -267,7 +267,8 @@ const templates = {
placeholderValue: string,
): HTMLInputElement {
const inp = Object.assign(document.createElement('input'), {
type: 'text',
type: 'search',
name: 'search_terms',
className: `${input} ${inputCloned}`,
autocomplete: 'off',
autocapitalize: 'off',