### 📖 Summary
Originally, the cache_to and cache_from were being converted into string arrays. Then their contents were looped over to add to the build command. This has the side affect of stopping the user from setting additional options for the cache-to and cache-from args since their command input format uses commas. i.e. `type=registry,ref=imagepath,mode=max` would result in `--cache-to type=registry --cache-to ref=imagepath --cache-to mode=max`. The command was not designed to be used that way.
The one reason I can think of for cache_to and cache_from to be arrays is so you could have multiple cache registries. But I can't confirm that the build command even works like this.
### 📑 Build PR Images?
PR images are not needed
### 💬 Details
_No response_
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/129
Reviewed-by: Patrick Schratz <pat-s@noreply.codeberg.org>
Co-authored-by: David Kovari <dakovari@gmail.com>
Co-committed-by: David Kovari <dakovari@gmail.com>
### 📖 Summary
Both essentially do the same until the very end - only one of each is needed respectively.
### 📑 Build PR Images?
PR images are not needed
### 💬 Details
_No response_
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/131
Reviewed-by: 6543 <6543@obermui.de>
Co-authored-by: pat-s <patrick.schratz@gmail.com>
Co-committed-by: pat-s <patrick.schratz@gmail.com>
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| docker | final | major | `24.0.7-dind` -> `25.0.0-dind` |
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/126
Co-authored-by: woodpecker-bot <woodpecker-bot@obermui.de>
Co-committed-by: woodpecker-bot <woodpecker-bot@obermui.de>
### 📖 Summary
fix usage of `dry-run` option in docs example. It is supposed to be `dry-run` and not `dry_run`.
See the current docs here: https://woodpecker-ci.org/plugins/Docker%20Buildx for an example
### 📑 Build PR Images?
PR images are not needed
### 💬 Details
_No response_
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/117
Reviewed-by: Lauris BH <lafriks@noreply.codeberg.org>
Co-authored-by: bretello <bretello@distruzione.org>
Co-committed-by: bretello <bretello@distruzione.org>
Prefixing to make the settings easier to distinguish from non-ECR ones.
Also expanded the multi-repo push example.
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/115
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org>
Reviewed-by: 6543 <6543@obermui.de>
Co-authored-by: pat-s <patrick.schratz@gmail.com>
Co-committed-by: pat-s <patrick.schratz@gmail.com>
fix#74
Mainly borrowed from https://github.com/drone-plugins/drone-docker/tree/master/cmd/drone-ecr.
`drone/ecr` is still on 20.10.14 and sparsely updated/maintained. Would be great to add support for additional registries like ECR to buildx.
The login process is as follows:
1. Call the AWS API with some arguments to get a short-lived auth token (12h)
2. Use the token and Username `AWS` for the `docker login` call
## Notes
- To push to ECR, the full registry URL must be given in the tag, i.e. `registry/owner/repo`. For this, `Registry` must also be added the to `Build` struct besides the `Settings` struct
- For now I've only referenced the source in `ecr.go` by using the most recent commit of today. Should this be done differently?
- The implementation here from me is simple and probably a bit "naive" as this is my first "real" golang feature PR.
- I've tested this change with a custom image and was able to successfully push to ECR while dynamically creating a repository. Proper tests would still be great...
- Vars `assumeRole` and `externalID` are somehow not exposed in https://plugins.drone.io/plugins/ecr and I am not sure if this is by design or because they were just forgotten. Anyhow, this is reason I didn't expose them for now and just added internal dummy vars.
Co-authored-by: pat-s <patrick.schratz@gmail.com>
Co-committed-by: pat-s <patrick.schratz@gmail.com>
Current runs of the plugin output the following
```
WARNING: buildx: git was not found in the system. Current commit information was not captured by the build
```
adding `git` should solve this.
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/109
Reviewed-by: 6543 <6543@obermui.de>
Co-authored-by: pat-s <patrick.schratz@gmail.com>
Co-committed-by: pat-s <patrick.schratz@gmail.com>
This fixes an error in the documentation. Multiple tags in tags_file are separated by a newline instead of a comma.
See: 5116f6263f/plugin/impl.go (L138)
Reviewed-on: https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/107
Reviewed-by: Patrick Schratz <pat-s@noreply.codeberg.org>
Co-authored-by: Thomas Renes <thomas@renesweb.nl>
Co-committed-by: Thomas Renes <thomas@renesweb.nl>
